From: Dave Hansen <dave.hansen@intel.com>
To: Ard Biesheuvel <ardb@kernel.org>, linux-efi@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Kees Cook <keescook@chromium.org>,
Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v2 3/3] efi: x86: Wire up IBT annotation in memory attributes table
Date: Wed, 8 Feb 2023 07:17:15 -0800 [thread overview]
Message-ID: <ca9dc359-899b-ec69-36e0-17225189da01@intel.com> (raw)
In-Reply-To: <20230206124938.272988-4-ardb@kernel.org>
On 2/6/23 04:49, Ard Biesheuvel wrote:
> --- a/arch/x86/kernel/apm_32.c
> +++ b/arch/x86/kernel/apm_32.c
> @@ -609,7 +609,7 @@ static long __apm_bios_call(void *_call)
>
> apm_irq_save(flags);
> firmware_restrict_branch_speculation_start();
> - ibt = ibt_save();
> + ibt = ibt_save(true);
My only nit with these is the bare use of 'true'/'false'. It's
impossible to tell at the call-site what the 'true' means. So, if you
happen to respin these and see a nice way to remedy this I'd appreciate it.
But they're still OK as-is. For the x86 bits:
Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
next prev parent reply other threads:[~2023-02-08 15:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 12:49 [PATCH v2 0/3] efi: Enable BTI for EFI runtimes services Ard Biesheuvel
2023-02-06 12:49 ` [PATCH v2 1/3] efi: Discover BTI support in runtime services regions Ard Biesheuvel
2023-02-06 12:49 ` [PATCH v2 2/3] efi: arm64: Wire up BTI annotation in memory attributes table Ard Biesheuvel
2023-02-08 13:00 ` Will Deacon
2023-02-08 13:03 ` Ard Biesheuvel
2023-02-08 14:25 ` Mark Rutland
2023-02-08 14:36 ` Ard Biesheuvel
2023-02-09 14:21 ` Ard Biesheuvel
2023-02-09 15:13 ` Mark Rutland
2023-02-09 15:48 ` Will Deacon
2023-02-20 15:53 ` Mark Brown
2023-02-20 16:46 ` Ard Biesheuvel
2023-02-06 12:49 ` [PATCH v2 3/3] efi: x86: Wire up IBT " Ard Biesheuvel
2023-02-08 15:17 ` Dave Hansen [this message]
2023-02-08 20:14 ` Peter Zijlstra
2023-02-08 20:55 ` Mark Rutland
2023-02-09 16:13 ` Kees Cook
2023-02-09 16:23 ` Ard Biesheuvel
2023-02-09 16:27 ` Dave Hansen
2023-02-09 16:37 ` Kees Cook
2023-02-08 17:30 ` Peter Zijlstra
2023-02-08 12:35 ` [PATCH v2 0/3] efi: Enable BTI for EFI runtimes services Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca9dc359-899b-ec69-36e0-17225189da01@intel.com \
--to=dave.hansen@intel.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox