* [PATCH v2 0/3] pstore: resend three patches
@ 2015-11-07 4:43 Geliang Tang
[not found] ` <337377a3fbcf855d6a5217e06fcd8c8a979f2853.1446869434.git.geliangtang@163.com>
0 siblings, 1 reply; 9+ messages in thread
From: Geliang Tang @ 2015-11-07 4:43 UTC (permalink / raw)
To: Matt Fleming, Anton Vorontsov, Colin Cross, Kees Cook, Tony Luck
Cc: Geliang Tang, linux-efi-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
I sent these patches a few weeks ago. Due to the recent changes in pstore,
these patched might not apply anymore. So I refresh and resend them.
---
Changes in v2:
- refresh the patches.
---
Geliang Tang (3):
pstore: check PSTORE_FLAGS_FRAGILE in pstore_unregister
efi-pstore: implement efivars_pstore_exit()
pstore: drop file opened reference count
drivers/firmware/efi/efi-pstore.c | 7 +++++++
fs/pstore/inode.c | 1 -
fs/pstore/platform.c | 9 ++++++---
3 files changed, 13 insertions(+), 4 deletions(-)
--
2.5.0
^ permalink raw reply [flat|nested] 9+ messages in thread[parent not found: <337377a3fbcf855d6a5217e06fcd8c8a979f2853.1446869434.git.geliangtang@163.com>]
* [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit() [not found] ` <337377a3fbcf855d6a5217e06fcd8c8a979f2853.1446869434.git.geliangtang@163.com> @ 2015-11-07 4:43 ` Geliang Tang [not found] ` <c203e0cfee351d6f97c6a1a42c3e25b4be339f93.1446869434.git.geliangtang-9Onoh4P/yGk@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Geliang Tang @ 2015-11-07 4:43 UTC (permalink / raw) To: Matt Fleming, Anton Vorontsov, Colin Cross, Kees Cook, Tony Luck Cc: Geliang Tang, linux-efi, linux-kernel The original efivars_pstore_exit() is empty. I 1) add a bufsize check statement. 2) call pstore_unregister as it is defined now. 3) free the memory and set bufsize to 0. Signed-off-by: Geliang Tang <geliangtang@163.com> --- drivers/firmware/efi/efi-pstore.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c index eac76a7..62d57d8 100644 --- a/drivers/firmware/efi/efi-pstore.c +++ b/drivers/firmware/efi/efi-pstore.c @@ -393,6 +393,13 @@ static __init int efivars_pstore_init(void) static __exit void efivars_pstore_exit(void) { + if (!efi_pstore_info.bufsize) + return; + + pstore_unregister(&efi_pstore_info); + kfree(efi_pstore_info.buf); + efi_pstore_info.buf = NULL; + efi_pstore_info.bufsize = 0; } module_init(efivars_pstore_init); -- 2.5.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
[parent not found: <c203e0cfee351d6f97c6a1a42c3e25b4be339f93.1446869434.git.geliangtang-9Onoh4P/yGk@public.gmane.org>]
* Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit() [not found] ` <c203e0cfee351d6f97c6a1a42c3e25b4be339f93.1446869434.git.geliangtang-9Onoh4P/yGk@public.gmane.org> @ 2015-11-11 16:59 ` Matt Fleming 2015-11-11 23:08 ` Kees Cook 0 siblings, 1 reply; 9+ messages in thread From: Matt Fleming @ 2015-11-11 16:59 UTC (permalink / raw) To: Geliang Tang Cc: Anton Vorontsov, Colin Cross, Kees Cook, Tony Luck, linux-efi-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA On Sat, 07 Nov, at 12:43:48PM, Geliang Tang wrote: > The original efivars_pstore_exit() is empty. I > 1) add a bufsize check statement. > 2) call pstore_unregister as it is defined now. > 3) free the memory and set bufsize to 0. > > Signed-off-by: Geliang Tang <geliangtang-9Onoh4P/yGk@public.gmane.org> > --- > drivers/firmware/efi/efi-pstore.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c > index eac76a7..62d57d8 100644 > --- a/drivers/firmware/efi/efi-pstore.c > +++ b/drivers/firmware/efi/efi-pstore.c > @@ -393,6 +393,13 @@ static __init int efivars_pstore_init(void) > > static __exit void efivars_pstore_exit(void) > { > + if (!efi_pstore_info.bufsize) > + return; > + > + pstore_unregister(&efi_pstore_info); > + kfree(efi_pstore_info.buf); > + efi_pstore_info.buf = NULL; > + efi_pstore_info.bufsize = 0; > } > > module_init(efivars_pstore_init); Looks OK to me. Kees, are you picking this up? ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit() 2015-11-11 16:59 ` Matt Fleming @ 2015-11-11 23:08 ` Kees Cook [not found] ` <CAGXu5j+DADxC6LrHMSAnw5N2GRFbby6-iPTgkKC=BZotBqt-NQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Kees Cook @ 2015-11-11 23:08 UTC (permalink / raw) To: Matt Fleming Cc: Geliang Tang, Anton Vorontsov, Colin Cross, Tony Luck, linux-efi@vger.kernel.org, LKML On Wed, Nov 11, 2015 at 8:59 AM, Matt Fleming <matt@codeblueprint.co.uk> wrote: > On Sat, 07 Nov, at 12:43:48PM, Geliang Tang wrote: >> The original efivars_pstore_exit() is empty. I >> 1) add a bufsize check statement. >> 2) call pstore_unregister as it is defined now. >> 3) free the memory and set bufsize to 0. >> >> Signed-off-by: Geliang Tang <geliangtang@163.com> >> --- >> drivers/firmware/efi/efi-pstore.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c >> index eac76a7..62d57d8 100644 >> --- a/drivers/firmware/efi/efi-pstore.c >> +++ b/drivers/firmware/efi/efi-pstore.c >> @@ -393,6 +393,13 @@ static __init int efivars_pstore_init(void) >> >> static __exit void efivars_pstore_exit(void) >> { >> + if (!efi_pstore_info.bufsize) >> + return; >> + >> + pstore_unregister(&efi_pstore_info); >> + kfree(efi_pstore_info.buf); >> + efi_pstore_info.buf = NULL; >> + efi_pstore_info.bufsize = 0; >> } >> >> module_init(efivars_pstore_init); > > Looks OK to me. Kees, are you picking this up? I can, though usually it goes through Tony. -Kees -- Kees Cook Chrome OS Security ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <CAGXu5j+DADxC6LrHMSAnw5N2GRFbby6-iPTgkKC=BZotBqt-NQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* RE: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit() [not found] ` <CAGXu5j+DADxC6LrHMSAnw5N2GRFbby6-iPTgkKC=BZotBqt-NQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2015-11-11 23:23 ` Luck, Tony [not found] ` <3908561D78D1C84285E8C5FCA982C28F32B86A52-8oqHQFITsIE64kNsxIetb7fspsVTdybXVpNB7YpNyf8@public.gmane.org> 2015-11-12 12:22 ` Matt Fleming 0 siblings, 2 replies; 9+ messages in thread From: Luck, Tony @ 2015-11-11 23:23 UTC (permalink / raw) To: Kees Cook, Matt Fleming Cc: Geliang Tang, Anton Vorontsov, Colin Cross, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LKML >>> module_init(efivars_pstore_init); >> >> Looks OK to me. Kees, are you picking this up? > > I can, though usually it goes through Tony. Can I count that as "Acked-by" from both of you? -Tony ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <3908561D78D1C84285E8C5FCA982C28F32B86A52-8oqHQFITsIE64kNsxIetb7fspsVTdybXVpNB7YpNyf8@public.gmane.org>]
* Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit() [not found] ` <3908561D78D1C84285E8C5FCA982C28F32B86A52-8oqHQFITsIE64kNsxIetb7fspsVTdybXVpNB7YpNyf8@public.gmane.org> @ 2015-11-11 23:24 ` Kees Cook [not found] ` <CAGXu5j+PZwpcRTNFpTYzw-Fs6OJLdvaNDGq=vsW7iEhWunc+8g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Kees Cook @ 2015-11-11 23:24 UTC (permalink / raw) To: Luck, Tony Cc: Matt Fleming, Geliang Tang, Anton Vorontsov, Colin Cross, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LKML On Wed, Nov 11, 2015 at 3:23 PM, Luck, Tony <tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote: >>>> module_init(efivars_pstore_init); >>> >>> Looks OK to me. Kees, are you picking this up? >> >> I can, though usually it goes through Tony. > > Can I count that as "Acked-by" from both of you? Yup, sorry. I thought I'd acked them already. :) My bad! Acked-by: Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> -Kees -- Kees Cook Chrome OS Security ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <CAGXu5j+PZwpcRTNFpTYzw-Fs6OJLdvaNDGq=vsW7iEhWunc+8g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit() [not found] ` <CAGXu5j+PZwpcRTNFpTYzw-Fs6OJLdvaNDGq=vsW7iEhWunc+8g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2016-06-02 7:26 ` Geliang Tang, Kees Cook 2016-06-02 18:26 ` Kees Cook 0 siblings, 1 reply; 9+ messages in thread From: Geliang Tang, Kees Cook @ 2016-06-02 7:26 UTC (permalink / raw) To: Kees Cook, Luck, Tony Cc: Matt Fleming, Anton Vorontsov, Colin Cross, linux-efi-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Geliang Tang On Wed, Nov 11, 2015 at 03:24:33PM -0800, Kees Cook wrote: > On Wed, Nov 11, 2015 at 3:23 PM, Luck, Tony <tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote: > >>>> module_init(efivars_pstore_init); > >>> > >>> Looks OK to me. Kees, are you picking this up? > >> > >> I can, though usually it goes through Tony. > > > > Can I count that as "Acked-by" from both of you? > > Yup, sorry. I thought I'd acked them already. :) My bad! > > Acked-by: Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> > Hi Kees, Could you please apply these three pending patches for me? I think they are still valid. Thank you very much. -Geliang > -Kees > > -- > Kees Cook > Chrome OS Security ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit() 2016-06-02 7:26 ` Geliang Tang, Kees Cook @ 2016-06-02 18:26 ` Kees Cook 0 siblings, 0 replies; 9+ messages in thread From: Kees Cook @ 2016-06-02 18:26 UTC (permalink / raw) To: Geliang Tang, Kees Cook Cc: Luck, Tony, Matt Fleming, Anton Vorontsov, Colin Cross, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LKML On Thu, Jun 2, 2016 at 12:26 AM, Geliang Tang <geliangtang-9Onoh4P/yGk@public.gmane.org> wrote: > On Wed, Nov 11, 2015 at 03:24:33PM -0800, Kees Cook wrote: >> On Wed, Nov 11, 2015 at 3:23 PM, Luck, Tony <tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote: >> >>>> module_init(efivars_pstore_init); >> >>> >> >>> Looks OK to me. Kees, are you picking this up? >> >> >> >> I can, though usually it goes through Tony. >> > >> > Can I count that as "Acked-by" from both of you? >> >> Yup, sorry. I thought I'd acked them already. :) My bad! >> >> Acked-by: Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> >> > > Hi Kees, > > Could you please apply these three pending patches for me? > I think they are still valid. Thank you very much. Yes, added to my for-next tree now. Thanks! -Kees -- Kees Cook Chrome OS & Brillo Security ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit() 2015-11-11 23:23 ` Luck, Tony [not found] ` <3908561D78D1C84285E8C5FCA982C28F32B86A52-8oqHQFITsIE64kNsxIetb7fspsVTdybXVpNB7YpNyf8@public.gmane.org> @ 2015-11-12 12:22 ` Matt Fleming 1 sibling, 0 replies; 9+ messages in thread From: Matt Fleming @ 2015-11-12 12:22 UTC (permalink / raw) To: Luck, Tony Cc: Kees Cook, Geliang Tang, Anton Vorontsov, Colin Cross, linux-efi@vger.kernel.org, LKML On Wed, 11 Nov, at 11:23:15PM, Luck, Tony wrote: > >>> module_init(efivars_pstore_init); > >> > >> Looks OK to me. Kees, are you picking this up? > > > > I can, though usually it goes through Tony. > > Can I count that as "Acked-by" from both of you? Yep, Acked-by: Matt Fleming <matt@codeblueprint.co.uk> ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-06-02 18:26 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-07 4:43 [PATCH v2 0/3] pstore: resend three patches Geliang Tang
[not found] ` <337377a3fbcf855d6a5217e06fcd8c8a979f2853.1446869434.git.geliangtang@163.com>
2015-11-07 4:43 ` [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit() Geliang Tang
[not found] ` <c203e0cfee351d6f97c6a1a42c3e25b4be339f93.1446869434.git.geliangtang-9Onoh4P/yGk@public.gmane.org>
2015-11-11 16:59 ` Matt Fleming
2015-11-11 23:08 ` Kees Cook
[not found] ` <CAGXu5j+DADxC6LrHMSAnw5N2GRFbby6-iPTgkKC=BZotBqt-NQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-11-11 23:23 ` Luck, Tony
[not found] ` <3908561D78D1C84285E8C5FCA982C28F32B86A52-8oqHQFITsIE64kNsxIetb7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-11-11 23:24 ` Kees Cook
[not found] ` <CAGXu5j+PZwpcRTNFpTYzw-Fs6OJLdvaNDGq=vsW7iEhWunc+8g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-02 7:26 ` Geliang Tang, Kees Cook
2016-06-02 18:26 ` Kees Cook
2015-11-12 12:22 ` Matt Fleming
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).