From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Christian Brauner <brauner@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>
Cc: "Ard Biesheuvel" <ardb@kernel.org>,
linux-efi@vger.kernel.org, linux-fsdevel@vger.kernel.org,
"Ryan Lee" <ryan.lee@canonical.com>,
"Malte Schröder" <malte.schroeder@tnxip.de>
Subject: Re: [PATCH] efivarfs: fix NULL dereference on resume
Date: Tue, 18 Mar 2025 10:52:11 -0400 [thread overview]
Message-ID: <d452ec4ae5d5139e23f751c6af9f0f87ccc76ff1.camel@HansenPartnership.com> (raw)
In-Reply-To: <20250318-ovale-ausziehen-94ede9b50d75@brauner>
On Tue, 2025-03-18 at 15:13 +0100, Christian Brauner wrote:
> > (which is what that vfs_kern_mount() boils down to). But I would
> > very much prefer to have it go over the list of children of -
> > >s_root manually, instead of playing silly buggers with
> > iterate_dir().
>
> This is what I suggested earlier in the thread to rewrite it to not
> rely on files. That's probably the full-on fix we want later.
So as I said in the other reply, I think I can do that as a libfs.c
helper. However, it definitely won't be -fixes material and since this
is a current bug, is it OK if the patch goes up as is and I'll do the
rewrite for the merge window branch (and probably the next merge window
not this one, given where we are)? If I haven't got something by
LSF/MM you can yell at me in person ...
Regards,
James
prev parent reply other threads:[~2025-03-18 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 3:06 [PATCH] efivarfs: fix NULL dereference on resume James Bottomley
2025-03-18 3:37 ` Al Viro
2025-03-18 7:04 ` Ard Biesheuvel
2025-03-18 7:49 ` Al Viro
2025-03-18 12:15 ` James Bottomley
2025-03-18 14:13 ` Christian Brauner
2025-03-18 14:52 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d452ec4ae5d5139e23f751c6af9f0f87ccc76ff1.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=ardb@kernel.org \
--cc=brauner@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=malte.schroeder@tnxip.de \
--cc=ryan.lee@canonical.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox