Re: [PATCHv8 04/17] x86/cpu: Defer CR pinning setup until after EFI initialization

Kirill A. Shutemov
2025-07-04T12:23:35Z

On Wed, Jul 02, 2025 at 01:05:23PM +0300, Kirill A. Shutemov wrote:
> On Tue, Jul 01, 2025 at 04:10:19PM -0700, Dave Hansen wrote:
> > On 7/1/25 02:58, Kirill A. Shutemov wrote:
> > > Move CR pinning setup behind the EFI initialization.
> >
> > I kinda grumble about these one-off solutions. Could we just do this
> > once and for all and defer CR pinning as long as possible? For instance,
> > could we do it in a late_initcall()?
> >
> > Do we need pinning before userspace comes up?
>
> Hm. I operated from an assumption that we want to pin control registers as
> early as possible to get most benefit from it.
>
> I guess we can defer it until later. But I am not sure late_initcall() is
> the right place. Do we want random driver to twiddle control registers?

I will do it in core_initcall().

--
Kiryl Shutsemau / Kirill A. Shutemov