Re: [PATCHv8 14/17] x86/traps: Handle LASS thrown #SS

Sohil Mehta
2025-07-02T17:56:51Z

On 7/2/2025 6:27 AM, Kirill A. Shutemov wrote:
>>> +
>>> + if (cpu_feature_enabled(X86_FEATURE_LASS)) {
>>> + enum kernel_exc_hint hint;
>>> + unsigned long exc_addr;
>>> +
>>> + hint = get_kernel_exc_address(regs, &exc_addr);
>>> + if (hint != EXC_NO_HINT) {
>>
>> The brackets are not needed for singular statements. Also the max line
>> length is longer now. You can fit this all in a single line.
>
> I think line split if justified. It is 120 characters long otherwise.
> And with multi-line statement, brackets help readability.
>

Are you sure? Below ends at 90 characters for me, including the three
8-char tabs:

printk(SSFSTR ", %s 0x%lx", kernel_exc_hint_help[hint], exc_addr);

> I don't see a reason to change it.

To reduce indentation, you could also do:

if (!cpu_feature_enabled(X86_FEATURE_LASS))
goto error_trap;

>
>>> + printk(SSFSTR ", %s 0x%lx", kernel_exc_hint_help[hint],
>>> + exc_addr);
>>> + }
>>> +
>>