Re: [PATCH v10 04/15] x86/cpu: Set LASS CR4 bit as pinning sensitive

Edgecombe, Rick P
2025-10-07T18:24:12Z

On Mon, 2025-10-06 at 23:51 -0700, Sohil Mehta wrote:
> From: Yian Chen <yian.chen@intel.com>
>
> Security features such as LASS are not expected to be disabled once
> initialized. Add LASS to the CR4 pinned mask.
>
> Signed-off-by: Yian Chen <yian.chen@intel.com>
> Signed-off-by: Sohil Mehta <sohil.mehta@intel.com>

I was debating whether we really need this, given the LASS and CR pinning threat
models. CR pinning seems to be about after an attacker has already hijacked a
control flow and is looking to escalate it into more control. We could maybe get
away with dropping this and the following patch. But it would still be good to
get a warning if it gets turned off inadvertently I think. It might be worth
adding justification like that to the log.