From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794929138; b=ts8dxujUQ8I6JWEfgHTrSUI20+j6gmG3HAFUOjAUwoVAUZ18ce4xsWaOppycT/b3S2jI SbtSnA4hd1gkoRiqzqkYMYHwkDLNIxknIR5XpHaVgqa29EVb9mKt3zETuaUG6h3cF+N5m TENpxM+EmBVlWU3DVLJFqd2UKnqPxjaZ0olryEtGQBvZx4XcelBPnOrQNuRyLpBajtZtX 11iHfOiq0ImvJtfgLrLgGOM+Z2XSw8zYHUImw4KDvpebtaaBTtPh2T6I4sadvZgQw3EjH ge5Tw9rcv6+q/Wl9Hm2moGVUu/C2ra44yTLp/EMKSCfT5ZvPSAypmpSpt/eQWX4wK0Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794929138; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=mLpPRRwJinjCyS610srEJx7KpX4KJuB1wBOk4FmMCNg=; b=Ljxr3+VpmINI15YXYkIS40EW1FRhTj0hEGWism8bLzOkZoegS5W+WVKkqNpJU363ZkbT /rIkwXQVqMhksWph0GDhdvbBVZQoacrxNdn4igm+wj0eqYHkl4Bo0DjRqsn/+6b6Woyas eSDAijDarI/9RTwa5M/zmxN56t6ZjTRo7yhQQ/IecU3xg6f/vEXanZTz7kUdpmQNxdpBW wt9CNGEamEunq4aAzFHLAf3ASF7RN3DheEniTpUQOnuTSAA/dNfLnX/QZZuRyVnPIgrds mvuqOB/2o+mtGATv9b+ui1whmYTlbiqNpmRfy1WGqxJyWYSVUU124Ni0h0Zx1Ke0wUw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=iNxzJ0p6; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26503606A32C; Tue, 17 Nov 2026 15:25:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=iNxzJ0p6 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E2F71F000C4; Tue, 17 Nov 2026 15:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794929138; bh=mLpPRRwJinjCyS610srEJx7KpX4KJuB1wBOk4FmMCNg=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=iNxzJ0p6q33rtHMw07jyxEgdwHPdz5eejr1sEWqi9xCD2Bc4mQVnJoYzm1WGPOJoZ DRL6HpDx1vpbiNEWrl2AhexzG1dNH2Q6KkDTlfAvBa5CyPAcvDTr/WD99mr40wkf8t KIlpI6W/Yib6/Z9UGdn9DLJd20z9B91KOeLM3B0CtnKeGnvaMQKchT3zLCwLtQJOQ7 PYaIeM0AKmDZolC/t+aj6GZO0IrC4WNs902Ngh+FbYm+spAoOAbywGGBTPAjqegfGu Npb3+1axe7tYaxOAZgrTTJ3i5KmiwKXXl0PyL5ELQiKXoCZaWXc1Y7+uQ4Mzi5O7j3 ozPtISvowmFDw== Message-ID: Date: Tue, 17 Nov 2026 16:25:32 +0100 X-Mailing-List: linux-efi@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 0/6] PSCI-via-EFI to support firmware and kernel sharing EL2 for Apple Silicon To: Will Deacon Cc: Ard Biesheuvel , Mark Rutland , Lorenzo Pieralisi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ilias Apalodimas , Catalin Marinas , Sudeep Holla , Janne Grunau , Neal Gompa , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, asahi@lists.linux.dev References: <20260708-efi-psci-v1-0-9efb3abf0e4c@kernel.org> <9c53cfd7-e193-4441-83ca-7710060225b7@app.fastmail.com> Content-Language: en-US From: Sven Peter In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 17.11.26 13:10, Will Deacon wrote: > On Sun, Nov 15, 2026 at 07:38:35PM +0100, Sven Peter wrote: >> >> >> On 03.09.26 15:25, Ard Biesheuvel wrote: >>> On Thu, 3 Sep 2026, at 14:15, Will Deacon wrote: >>>> On Thu, Sep 03, 2026 at 12:42:39PM +0100, Mark Rutland wrote: >>>>> On Thu, Sep 03, 2026 at 01:34:56PM +0200, Ard Biesheuvel wrote: >>>>>> On Wed, 8 Jul 2026, at 09:15, Sven Peter wrote: >>>>>>> This series adds a custom EFI table that points to a PSCI entry point >>>>>>> (plus some other stuff that has to be available before EFI runtime >>>>>>> services are set up) and adds support for this new conduit to the psci >>>>>>> code. We can't directly use the normal EFI runtime path because that one >>>>>>> takes a sleeping lock and we need to be able to call into PSCI from >>>>>>> atomic context during e.g. cpu bringup or during idle. >>>>>>> It also adds support for specifying the specific MAIR attributes for EFI >>>>>>> runtime mappings as defined in the latest UEFI spec since Apple Silicon >>>>>>> is rather allergic to using Device-nGnRnE vs. Device-nGnRE for its MMIO. >>>>> >>>>>>> dt-bindings: arm: psci: Add EFI conduit >>>>>>> arm64/efi: Add and parse custom PSCI EFI configuration table >>>>>>> efi: Add EFI_MEMORY_ISA_{MASK,VALID} >>>>>>> arm64/efi: Honor EFI_MEMORY_ISA_MASK for Device-nGnRnE vs -nGnRE >>>>>>> firmware/psci: Add EFI runtime conduit >>>>>>> arm64: dts: apple: t8103: Add PSCI and CPU idle states >>>>>>> >>>>>> >>>>>> I've picked up patches #3 and #4, which are useful in their own right. >>>>>> >>>>>> I'm not sure if the arm64 maintainers will want to consider this, but >>>>>> I think it's a reasonable compromise, as it puts the abstraction in >>>>>> the right place. >>>>> >>>>> Sorry for the late reply; I've been away almost all of August and I'm >>>>> slowly catching up on things. >>>>> >>>>> As with last time this was proposed (in abstract), I am not happy about >>>>> bodging an EFI conduit into PSCI, given that the manner in which state >>>>> is managed is completely different from SMCCC. >>>>> >>>>> If we need a mechanism for doing hotplug and/or idle without HVC/SMC, >>>>> that's one thing we can consider. I don't think we should pretend that >>>>> it is PSCI. >>>> >>>> What do you have in mind for an alternative mechanism? I understand your >>>> objection to this proposal, but at least it keeps the interface fairly >>>> high-level and avoids opening the flood gates for a bunch of SoC-specific >>>> idle routines. Are you thinking of extensions to the PSCI spec or >>>> something else? >>>> >>> >>> I can't speak for Mark, of course, but I could imagine EFI being used as a >>> conduit to provide a callable set of interfaces (with a rigorously defined >>> set of constraints such as the ones in this patch, i.e., reentrancy, no FP >>> or SIMD, not relying on ISA features that the OS needs to know about and >>> enable, etc). >>> >>> There is prior art here in ACPI PRM, which does something similar, and this >>> also relies on EFI runtime services. >>> >>> You'd still need to implement the CPU ops and a cpuidle driver afaict (no >>> expert here), but at least those would be coded against an interface that >>> the kernel itself specified, and can be made as generic as we choose to. >>> >>> Not saying this is all great, but it might be a worthwhile compromise to >>> consider. >> >> Finally getting back to this series... >> >> >> I'd definitely like to keep mapping the resident firmware using EFI runtime >> services because otherwise I'd have to duplicate a whole lot of tricky code >> to do the same thing via some other means (e.g. a device tree nodes that >> contains all mappings + callbacks) and I just don't see much value in that. >> >> I'm happy to just drop the PSCI part though and replace that with a simple >> and somewhat generic "efi-rt" (or similar) cpuidle driver and make that one >> have similar requirements like I added for this RFC series and expose bunch >> of generic callbacks (that will just happen to resemble PSCI functions very >> much ;)) via a custom EFI table. That would keep PSCI out of all of this but >> come at the cost of an additional cpuidle driver. >> >> I don't think that would open any flood gates for SoC-specific drivers since >> we could just point them to the generic one and tell them to use that one if >> they can't do PSCI for some reason. >> >> >> Now before I go off and prototype this: Would this approach be fine in >> general with you, Mark and Will? > > tbh, if the "efi-rt" thing is just PSCI with a different conduit and that > conduit is properly documented, then I really don't see the point in keeping > it separate. However. I suspect that we probably all have slightly different > opinions here which isn't going to help you very much :( Yeah, well, I agree but I really don't have a strong opinion or any good argument if either "efi-rt" vs "psci-via-efi" is better or worse. I only think both are better than SoC-specific cpuidle and cpu_ops drivers and I have no idea how else we could do this. (We could drop the kernel to EL1 and do "normal" PSCI in EL2 then but that would be much worse than either of those options imho) And especially with M4+ I'd like to have something that can go upstream because normal wfi loses most general purpose regs there and has to be disabled which is not great. I can also just prototype the efi-rt cpuidle+cpu_ops thing and then we can take a look at it as well and see if that's better than what I have in this series if that helps but I'd rather not spend that time if that has no chance of being accepted either. Sven