From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A611457E6E for ; Fri, 11 Sep 2026 11:57:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789127860; cv=none; b=Rq7JLM+yhBjagD8xEUsorkyYN0Z9vpLQkVd1qXJrsT2tpmLwjh/+UmNZX4sdxVMt8KzTz556nvmnEe/X7wqXOBxy0g8wVSZ36162n3PNNQmH0GSAXgmsNdP9PdjsRrEcIyMhgf/+kphnLFm3ORIok01fRWev8enc8ksyXBqt1RI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789127860; c=relaxed/simple; bh=1lRC8ZGjaJk1CFMMkFB+zwt0ch81ggJd9O2XFlK/4VY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V3T6JyUhl1123WWWhhVSYVIwWzUYvDjbEoVoeRqzPjFQLHcnRRePqixi9nqaIH3SW73NNH6+MlBbd/hpcUPlh/suTX8jUTWGJVdLgBg0zeN/jAsMyIZ0wwCzD7gjvtSG9A2fzX0TF64TanTymD+kQbmvxmSWry00YYQd2S3GObA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=cUBzSOOU; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="cUBzSOOU" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-49ccfbe062eso9542445e9.3 for ; Fri, 11 Sep 2026 04:57:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1789127856; x=1789732656; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wr7n2cO3L1gr9+vq7aPZsfQwfFiNJgEahYqoxuJotBY=; b=cUBzSOOUwzzqxDC+vpZBsvPZyne0rSo5Iv2fNaVmgBjouOyMtE6UfB8G9bsZefMktB dKs9pIMO+8B2F/GdHaOaMo+0h27j493jL7A9DkGlrh+J4/dzg7ykHEZC3tk9SY/s+s/I PU7xVdgEwQl+Eub1RVsJ6h7b40tYHFZ348G5S6M87Y7vJtLwcIIMWc0xJPEnLSZqE5iA pdnpef71I1Yn3dDf8LEQJ62R/6BKeuzVwbDmgxAlkDnt6eF0//hs6KPBH1FRNCgaNXRc pHzjD/fabk+Jsz7S5C+O491YMjAc9M6HMloUkXdPBUWgTiodBv+UX9UObFCTEW7lv2vt nkXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789127856; x=1789732656; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wr7n2cO3L1gr9+vq7aPZsfQwfFiNJgEahYqoxuJotBY=; b=tXqNDpX2etelrqaZTsixnKEqOiadGEvbU3u4kz8UHWVS+tSQAsuoPIlQK8HnucK+sH LOd8u0NKdZ/NqDnL0iuqQuz2XWJWBbPYbAu4cJAjTwpPfAz5jgEF8SOOPNgPK5c8/VTn oLiq6Z4sAOzsfmgQ7QMqNARiySqb0gRzhPe44x6BUTMdH9JJXB24jevRPKMbRe1oD1iW Igz7ScvW5SQQAtEGHM7j/VyF57M2DB9RLtctOQNBbm+UgyOjsJE2tZM1e4/b6LKzhWbY AxfNIh0dWPPWMP6bDQqHDUappBHbv0zOpy7UpYed8pSXTgQxPlmRKEJwWk+kX6BIvRe8 LP1g== X-Forwarded-Encrypted: i=1; AKwUvByxCHuBZjn49OFR9gPwW//cunuGhPDNay+8I0g2JB83kq/ZHBCJh43oJPBSepSamUdwXyPT+YMK1nE=@vger.kernel.org X-Gm-Message-State: AFuF++mxAZjcvh8LtrU7yzGisf4mg43Rgv9WvYgvYRJgERjHF9fY060Q u4onjFodl8Yj9vt6kwd/ncuvxJx9qLexU+GFkkVnhIsBc7utxxi+AK39nBDq1JJ0v4E= X-Gm-Gg: AYBFou3mqaggrMgNP0sryfYtQBS96sEium8Mv0FsKunmrZLg8a/iVAiWU76wEc2oj3z 3JPl30sw3+UMRirc47q9KdI3sU9CtKAopAUjurG6f2mpBqDB1rEhvQFkCWU9FZ1Ry3gFNdN1vZj kTFO+tgubS0QEofUcvWnNVyiae2MRC+RPmnIhYBbVrXfrkAEKfRN/jvIfaUfokm/vdT77gzriGu SEurSB1BiD7xj2KyjZ39rXOHj0QZp9NzLZkdWZ1iJKNkCo+iYX/xVouh89Pom5M5nKTUZqwzhAI lzs99OEkJjdodI8bEpTIOFbB9RG++hyE8V8952uYdI7JU2BMY5WwfRBqeb/ZsXrfHj+YKxtvuXp hjX8DTnZZVX+1qfMNmj2Nr5NgLizE1pBLfwYknl8AFO2hzzDsskXpvhAmYaHtcPD2AtyP25FM8O Ji+TrbsxE5lndyBiv3BiWHjhkrtIhGImd5erNtjNCGt4Cpod95HgFPQ27ATpuG8rfntKS8YgPQO LWilES3V3a7WMBo4YJaCe3as2rYMFy8511s X-Received: by 2002:a05:600d:8496:20b0:499:8aff:59b6 with SMTP id 5b1f17b1804b1-49e6199234amr30006585e9.14.1789127856324; Fri, 11 Sep 2026 04:57:36 -0700 (PDT) Received: from ?IPV6:2a07:de40:8100:0:89a9:fd0e:583d:4a53? ([2001:af0:8000:1409:193:86:92:181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49d26c300e2sm164777985e9.8.2026.09.11.04.57.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Sep 2026 04:57:35 -0700 (PDT) Message-ID: Date: Fri, 11 Sep 2026 13:57:34 +0200 Precedence: bulk X-Mailing-List: linux-efi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 13/23] modpost: hash module source per-file, not per-byte To: "Lorenzo Stoakes (ARM)" Cc: Linus Torvalds , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , Masahiro Yamada , Alexey Gladkov , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Arnd Bergmann , Catalin Marinas , Will Deacon , Mark Rutland , Ard Biesheuvel , Ilias Apalodimas , Josh Poimboeuf , Peter Zijlstra , Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?UTF-8?Q?Onur_=C3=96zkan?= , Jonathan Corbet , Randy Dunlap , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-doc@vger.kernel.org, Jens Axboe References: <20260908-build-speedup-v1-0-5dc1ac01672d@kernel.org> <20260908-build-speedup-v1-13-5dc1ac01672d@kernel.org> <434a7a10-d83e-4402-be91-816bbbc15bb7@suse.com> Content-Language: en-US From: Petr Pavlu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/11/26 12:41 PM, Lorenzo Stoakes (ARM) wrote: > On Thu, Sep 10, 2026 at 02:52:50PM +0200, Petr Pavlu wrote: >> On 9/8/26 10:55 PM, Lorenzo Stoakes (ARM) wrote: >>> modpost spends a long time md4 hashing module source at a per-byte >>> granularity. >>> >>> Fix this by doing this hashing per-file instead by accumulating a per-file >>> buffer in parse_file(). >>> >>> All 11,189 .mod.c files and Module.symvers were confirmed to be identical >>> with this change applied. >>> >>> This is especially impactful for allmodconfig incremental builds (where >>> CONFIG_MODULE_SRCVERSION_ALL is set). >>> >>> Whole build, 128-thread Threadripper 9980X, best of N runs: >>> >>> before after delta >>> ------------------------------- >>> x86 allmodconfig, touch mm/vma.c, gcc 40.6s 38.2s -2.4s (-6%) >>> x86 allmodconfig, touch mm/vma.c, clang 36.2s 35.0s -1.2s (-3%) >>> >>> Assisted-by: LLM >>> Signed-off-by: Lorenzo Stoakes (ARM) >>> --- >>> scripts/mod/sumversion.c | 56 +++++++++++++++++++++++++++++++++++++----------- >>> 1 file changed, 44 insertions(+), 12 deletions(-) >> >> Support for the module srcversion is being removed in "module: remove >> MODULE_VERSION() and srcversion" [1] and scripts/mod/sumversion.c should >> be gone completely. > > Hmm, that series doesn't remove the script though, is that planned as a follow up? My reply to that series [1] notes that it should also remove scripts/mod/sumversion.c. It should be done in the next version. > > I guess I can drop this patch from the series then :) Also patch 17 I think? I agree. The module srcversion is no longer needed since build IDs are nowadays the standard mechanism for providing effectively the same functionality. While I'm not sure when the mentioned removal will land, reviewing and polishing this patch and patch 17 would IMO be wasteful at this point. [1] https://lore.kernel.org/linux-modules/4e321525-708c-4964-9937-d94ea27e8d85@suse.com/ -- Thanks, Petr