From: Uros Bizjak <ubizjak@gmail.com>
To: Ard Biesheuvel <ardb+git@google.com>, linux-kernel@vger.kernel.org
Cc: linux-efi@vger.kernel.org, x86@kernel.org, mingo@kernel.org,
Ard Biesheuvel <ardb@kernel.org>,
Tom Lendacky <thomas.lendacky@amd.com>,
Dionna Amalie Glaze <dionnaglaze@google.com>,
Kevin Loughlin <kevinloughlin@google.com>
Subject: Re: [PATCH v5 6/6] x86/asm: Retire RIP_REL_REF()
Date: Fri, 18 Apr 2025 17:51:44 +0200 [thread overview]
Message-ID: <f465a1b3-c28b-7bfe-7c18-e3fad41842aa@gmail.com> (raw)
In-Reply-To: <20250418141253.2601348-14-ardb+git@google.com>
On 18. 04. 25 16:13, Ard Biesheuvel wrote:
> From: Ard Biesheuvel <ardb@kernel.org>
>
> Now that all users have been moved into startup/ where PIC codegen is
> used, RIP_REL_REF() is no longer needed. Remove it.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> arch/x86/include/asm/asm.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/x86/include/asm/asm.h b/arch/x86/include/asm/asm.h
> index a9f07799e337..eef0771512de 100644
> --- a/arch/x86/include/asm/asm.h
> +++ b/arch/x86/include/asm/asm.h
> @@ -120,11 +120,6 @@ static __always_inline __pure void *rip_rel_ptr(void *p)
>
> return p;
> }
> -#ifndef __pic__
> -#define RIP_REL_REF(var) (*(typeof(&(var)))rip_rel_ptr(&(var)))
> -#else
> -#define RIP_REL_REF(var) (var)
> -#endif
> #endif
You can also remove rip_rel_ptr() with the whole "#ifndef __ASSEMBLER__"
part.
Uros.
next prev parent reply other threads:[~2025-04-18 15:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 14:12 [PATCH v5 0/6] x86: Refactor and consolidate startup code Ard Biesheuvel
2025-04-18 14:12 ` [PATCH v5 1/6] vmlinux.lds: Include .data.rel[.local] into .data section Ard Biesheuvel
2025-04-18 14:12 ` [PATCH v5 2/6] x86/sev: Move noinstr NMI handling code into separate source file Ard Biesheuvel
2025-04-18 14:12 ` [PATCH v5 3/6] x86/sev: Split off startup code from core code Ard Biesheuvel
2025-04-23 15:22 ` Tom Lendacky
2025-04-23 15:50 ` Ard Biesheuvel
2025-04-24 9:37 ` Borislav Petkov
2025-04-24 15:34 ` [PATCH] x86/sev: Share the sev_secrets_pa value again Ingo Molnar
2025-04-24 16:04 ` Tom Lendacky
2025-04-18 14:12 ` [PATCH v5 4/6] x86/boot: Move SEV startup code into startup/ Ard Biesheuvel
2025-04-18 14:12 ` [PATCH v5 5/6] x86/boot: Drop RIP_REL_REF() uses from early SEV code Ard Biesheuvel
2025-04-18 14:13 ` [PATCH v5 6/6] x86/asm: Retire RIP_REL_REF() Ard Biesheuvel
2025-04-18 15:51 ` Uros Bizjak [this message]
2025-04-18 15:58 ` Ard Biesheuvel
2025-05-04 7:33 ` Uros Bizjak
2025-04-22 19:55 ` [PATCH v5 0/6] x86: Refactor and consolidate startup code Ingo Molnar
2025-04-22 21:09 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f465a1b3-c28b-7bfe-7c18-e3fad41842aa@gmail.com \
--to=ubizjak@gmail.com \
--cc=ardb+git@google.com \
--cc=ardb@kernel.org \
--cc=dionnaglaze@google.com \
--cc=kevinloughlin@google.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox