public inbox for linux-efi@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Walmsley <pjw@kernel.org>
To: Qiang Ma <maqianga@uniontech.com>
Cc: ardb@kernel.org, pjw@kernel.org, palmer@dabbelt.com,
	aou@eecs.berkeley.edu,  alex@ghiti.fr, linux-efi@vger.kernel.org,
	linux-riscv@lists.infradead.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH] efi/riscv: Remove the useless failure return message print
Date: Tue, 25 Nov 2025 17:27:30 -0700 (MST)	[thread overview]
Message-ID: <f9d632d5-22dc-8b14-8a70-37737a78f206@kernel.org> (raw)
In-Reply-To: <20251031024328.735161-1-maqianga@uniontech.com>

On Fri, 31 Oct 2025, Qiang Ma wrote:

> In the efi_create_mapping() in arch/riscv/kernel/efi.c,
> the return value is always 0, and this debug message
> is unnecessary. So, remove it.
> 
> Signed-off-by: Qiang Ma <maqianga@uniontech.com>

Considering that Ard doesn't think efi_create_mapping() should be changed 
to remove the return value, and that the ARM version of this code retains 
the debug message, we should probably keep things the way they are.  But 
if you can get a Reviewed-by: or an Acked-by: from Ard, I'd take it.


Thanks for your patch,

- Paul


  parent reply	other threads:[~2025-11-26  0:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-31  2:43 [PATCH] efi/riscv: Remove the useless failure return message print Qiang Ma
2025-10-31  4:12 ` Yao Zi
2025-10-31  6:52   ` Ard Biesheuvel
2025-10-31  8:27     ` Yao Zi
2025-11-26  0:27 ` Paul Walmsley [this message]
2025-11-26  2:49   ` Qiang Ma
2025-11-26  2:52   ` Qiang Ma
2025-11-26  6:38     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9d632d5-22dc-8b14-8a70-37737a78f206@kernel.org \
    --to=pjw@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=ardb@kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=maqianga@uniontech.com \
    --cc=palmer@dabbelt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox