public inbox for linux-efi@vger.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Budovski <vbudovski+news-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch] x86, efi: precedence error in setup_efi_pci()
Date: Tue, 29 Jan 2013 10:20:06 +0000 (UTC)	[thread overview]
Message-ID: <loom.20130129T111316-368@post.gmane.org> (raw)
In-Reply-To: 20121207061649.GA18220@elgon.mountain

Dan Carpenter <dan.carpenter@...> writes:

> 
> Negate has higher precedence than bitwise AND so the condition is always
> false.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...>
> index b1942e2..18e329c 100644
> -		if (!attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM)
> +		if (!(attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM))
 

Hi,

This patch breaks the detection of ATI VBIOS for me on a MacBook Pro 8,2.


Regards,

Vitaly

  parent reply	other threads:[~2013-01-29 10:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-07  6:16 [patch] x86, efi: precedence error in setup_efi_pci() Dan Carpenter
     [not found] ` <20121207061649.GA18220-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2012-12-08  3:05   ` H. Peter Anvin
     [not found]     ` <50C2AE91.9060800-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2012-12-10  8:44       ` Dan Carpenter
2013-01-11 13:52         ` Matt Fleming
2013-01-29 10:20 ` Vitaly Budovski [this message]
     [not found]   ` <loom.20130129T111316-368-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>
2013-01-29 11:04     ` Matt Fleming
     [not found]       ` <1359457448.8282.77.camel-ZqTwcBeJ+wsBof6jY8KHXm7IUlhRatedral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-01-29 11:16         ` H. Peter Anvin
     [not found]           ` <5107AF9F.8020800-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2013-01-29 11:30             ` Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20130129T111316-368@post.gmane.org \
    --to=vbudovski+news-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox