Re: [PATCH 07/10] x86: fix duplicate extern declarations

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] x86: commit message corrupted by shell expansion and inaccurate
  for .c files
--

commit ef771365acc78fbcdae41e8e72ef9a5cfb5a3f35
Author: Safocl Stollmannovic <safocl88@gmail.com>

> x86: fix duplicate extern declarations
>
> Compiling a kernel module with a C++ compiler results in a duplicate
> echo ‘extern’ specifier error.
> This occurs because the code contains , and
> expands to  when processed by a C++ compiler.
> The  specifier must be removed.
> https://bugzilla.kernel.org/show_bug.cgi?id=222257
>
> Signed-off-by: Safocl Stollmannovic <safocl88@gmail.com>

[Severity: Low]
Was the commit message corrupted by unescaped shell command substitution?
The terms "extern asmlinkage", "asmlinkage", "extern \"C\"", and "extern"
are missing from the sentences, and a stray "echo" appears on the second
line.

Also, is the C++ module rationale accurate here?  The kernel does not
support compiling modules or internal headers with a C++ compiler, and
arch/x86/um/sys_call_table_32.c and arch/x86/um/sys_call_table_64.c are C
translation units rather than headers included by modules.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113001432.128201-1-safocl88@gmail.com?part=7