public inbox for linux-efi@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Hedi Berriche <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-efi@vger.kernel.org, rja@hpe.com, x86@kernel.org,
	bp@suse.de, ard.biesheuvel@linaro.org, sivanich@hpe.com,
	mingo@kernel.org, mingo@redhat.com, dvhart@infradead.org,
	hpa@zytor.com, tglx@linutronix.de, bhsharma@redhat.com,
	mike.travis@hpe.com, steve.wahl@hpe.com,
	linux-kernel@vger.kernel.org, andy@infradead.org,
	hedi.berriche@hpe.com
Subject: [tip:x86/uv] x86/platform/UV: Remove unnecessary #ifdef CONFIG_EFI
Date: Fri, 15 Feb 2019 07:04:11 -0800	[thread overview]
Message-ID: <tip-30ad3e031d2feae075cd5fd2c443baa2d86c0195@git.kernel.org> (raw)
In-Reply-To: <20190213193413.25560-2-hedi.berriche@hpe.com>

Commit-ID:  30ad3e031d2feae075cd5fd2c443baa2d86c0195
Gitweb:     https://git.kernel.org/tip/30ad3e031d2feae075cd5fd2c443baa2d86c0195
Author:     Hedi Berriche <hedi.berriche@hpe.com>
AuthorDate: Wed, 13 Feb 2019 19:34:10 +0000
Committer:  Borislav Petkov <bp@suse.de>
CommitDate: Fri, 15 Feb 2019 15:05:15 +0100

x86/platform/UV: Remove unnecessary #ifdef CONFIG_EFI

CONFIG_EFI is implied by CONFIG_X86_UV and x86/platform/uv/bios_uv.c
requires the latter, get rid of the redundant #ifdef CONFIG_EFI
directives.

Cleanup, no functional changes.

Signed-off-by: Hedi Berriche <hedi.berriche@hpe.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Russ Anderson <rja@hpe.com>
Reviewed-by: Dimitri Sivanich <sivanich@hpe.com>
Reviewed-by: Mike Travis <mike.travis@hpe.com>
Cc: Andy Shevchenko <andy@infradead.org>
Cc: Bhupesh Sharma <bhsharma@redhat.com>
Cc: Darren Hart <dvhart@infradead.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: linux-efi <linux-efi@vger.kernel.org>
Cc: platform-driver-x86@vger.kernel.org
Cc: Steve Wahl <steve.wahl@hpe.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: x86-ml <x86@kernel.org>
Link: https://lkml.kernel.org/r/20190213193413.25560-2-hedi.berriche@hpe.com
---
 arch/x86/include/asm/uv/bios.h | 4 ----
 arch/x86/platform/uv/bios_uv.c | 2 --
 2 files changed, 6 deletions(-)

diff --git a/arch/x86/include/asm/uv/bios.h b/arch/x86/include/asm/uv/bios.h
index e652a7cc6186..00d862cfbcbe 100644
--- a/arch/x86/include/asm/uv/bios.h
+++ b/arch/x86/include/asm/uv/bios.h
@@ -151,11 +151,7 @@ extern s64 uv_bios_change_memprotect(u64, u64, enum uv_memprotect);
 extern s64 uv_bios_reserved_page_pa(u64, u64 *, u64 *, u64 *);
 extern int uv_bios_set_legacy_vga_target(bool decode, int domain, int bus);
 
-#ifdef CONFIG_EFI
 extern void uv_bios_init(void);
-#else
-void uv_bios_init(void) { }
-#endif
 
 extern unsigned long sn_rtc_cycles_per_second;
 extern int uv_type;
diff --git a/arch/x86/platform/uv/bios_uv.c b/arch/x86/platform/uv/bios_uv.c
index 4a6a5a26c582..4a61ed2a7bb8 100644
--- a/arch/x86/platform/uv/bios_uv.c
+++ b/arch/x86/platform/uv/bios_uv.c
@@ -188,7 +188,6 @@ int uv_bios_set_legacy_vga_target(bool decode, int domain, int bus)
 }
 EXPORT_SYMBOL_GPL(uv_bios_set_legacy_vga_target);
 
-#ifdef CONFIG_EFI
 void uv_bios_init(void)
 {
 	uv_systab = NULL;
@@ -218,4 +217,3 @@ void uv_bios_init(void)
 	}
 	pr_info("UV: UVsystab: Revision:%x\n", uv_systab->revision);
 }
-#endif

  reply	other threads:[~2019-02-15 15:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-13 19:34 [Patch v3 0/4] Protect against concurrent calls into UV BIOS Hedi Berriche
2019-02-13 19:34 ` [Patch v3 1/4] x86/platform/UV: remove unnecessary #ifdef CONFIG_EFI Hedi Berriche
2019-02-15 15:04   ` tip-bot for Hedi Berriche [this message]
2019-02-13 19:34 ` [Patch v3 2/4] x86/platform/UV: kill uv_bios_call_reentrant() Hedi Berriche
2019-02-15 15:04   ` [tip:x86/uv] x86/platform/UV: Remove uv_bios_call_reentrant() tip-bot for Hedi Berriche
2019-02-13 19:34 ` [Patch v3 3/4] x86/platform/UV: use efi_enabled() instead of test_bit() Hedi Berriche
2019-02-15 15:05   ` [tip:x86/uv] x86/platform/UV: Use " tip-bot for Hedi Berriche
2019-02-13 19:34 ` [Patch v3 4/4] x86/platform/UV: use efi_runtime_lock to serialise BIOS calls Hedi Berriche
2019-02-15 15:01   ` [tip:x86/urgent] x86/platform/UV: Use " tip-bot for Hedi Berriche
2019-02-14  8:17 ` [Patch v3 0/4] Protect against concurrent calls into UV BIOS Ard Biesheuvel
2019-02-14 21:08   ` Russ Anderson
2019-02-14 21:21 ` Dimitri Sivanich
2019-02-14 21:31   ` Mike Travis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-30ad3e031d2feae075cd5fd2c443baa2d86c0195@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=andy@infradead.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=bhsharma@redhat.com \
    --cc=bp@suse.de \
    --cc=dvhart@infradead.org \
    --cc=hedi.berriche@hpe.com \
    --cc=hpa@zytor.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mike.travis@hpe.com \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=rja@hpe.com \
    --cc=sivanich@hpe.com \
    --cc=steve.wahl@hpe.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox