From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PWM PATCH 2/5] Emulates PWM hardware using a high-resolution timer and a GPIO pin Date: Fri, 12 Feb 2010 14:13:11 +0100 Message-ID: <10f740e81002120513y457de2afqa155441941261f7a@mail.gmail.com> References: <2d73f9b2fd175fd3e482920baebcd3028206f02e.1265094517.git.bgat@billgatliff.com> <20100211200702.GB1487@ucw.cz> <4B746A02.9060306@billgatliff.com> <20100211205801.GA29159@elf.ucw.cz> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type; bh=TP9BxShPhfZfo7q0oOmSrCRaqpOjdl987HKUAClKBRM=; b=XsxEh2pBY4T72sjbOf0l4IfxLYiPqG849FB6Y9HqsL/dOiNHgLX24nm0Xcq0NbW44C CHW1aI6+IpOHg3UQY1ZWdKN1TkCC8zNCNGi3unzFArpNMEG4+kV6ZcByVK0BJlk/d/4N aLFr8XsJKC7CZAUZgXhU8aWJ8avzs5EHEqNQM= In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Stanislav O. Bezzubtsev" Cc: Pavel Machek , Bill Gatliff , linux-embedded@vger.kernel.org, linux-kernel@vger.kernel.org 2010/2/12 Stanislav O. Bezzubtsev : > The second strange thing is "unsigned long :1". I'm not sure but as far as I can remember the right way to define several-bits field is "int :1". But I might be mistaken. A bitfield of size 1 should not be signed, as there's no space for a sign bit. Usually, you want all bitfields to be unsigned anyway. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds