From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Woodhouse Subject: Re: [PATCH 14/23] make section names compatible with -ffunction-sections -fdata-sections: parisc Date: Wed, 02 Jul 2008 09:41:47 +0100 Message-ID: <1214988107.10393.444.camel@pmac.infradead.org> References: <200807020239.11410.vda.linux@googlemail.com> <1214955660.3316.31.camel@localhost.localdomain> <200807020200.49518.vda.linux@googlemail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200807020200.49518.vda.linux@googlemail.com> Sender: linux-arch-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Denys Vlasenko Cc: James Bottomley , linux-arch@vger.kernel.org, Russell King , David Howells , Ralf Baechle , Lennert Buytenhek , Josh Boyer , Paul Mackerras , Andi Kleen , torvalds@linux-foundation.org, akpm@linux-foundation.org, Paul Gortmaker , linux-embedded@vger.kernel.org, linux-kernel@vger.kernel.org, Tim Bird , Martin Schwidefsky , Dave Miller On Wed, 2008-07-02 at 02:00 +0200, Denys Vlasenko wrote: > On Wednesday 02 July 2008 01:41, James Bottomley wrote: > > On Wed, 2008-07-02 at 02:39 +0200, Denys Vlasenko wrote: > > > The purpose of this patch is to make kernel buildable > > > with "gcc -ffunction-sections -fdata-sections". > > > This patch fixes parisc architecture. > > > > > > Signed-off-by: Denys Vlasenko > > > > Um ... if you look at the Makefile you'll see we already build parisc > > with -ffunction-sections; we have to: our relative jumps are too small > > to guarantee finding the stubs in large files. > > > > Since our text is -ffunction-sections compatible already, I question the > > need for transformations like this: We've been building FR-V kernels with --gc-sections for a long time, too. > In order to handle these situations uniformly, in these patches > I decided to _never_ use .text.XXXX names for sections, > effectively leaving them "reserved for gcc's use". It makes a certain amount of sense to do this uniformly for all architectures -- leaving .text.* and .data.* for GCC, and using something else whenever we manually name sections. Denys' patch for parisc would need a little more thought, but it's probably worth it to be consistent. Especially if we can move more stuff out of athe arch-specific linker scripts and into -- dwmw2