From: Matt Mackall <mpm@selenic.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Tim Bird <tim.bird@am.sony.com>,
Robert Schwebel <r.schwebel@pengutronix.de>,
linux kernel <linux-kernel@vger.kernel.org>,
linux-embedded <linux-embedded@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] bootup: Add built-in kernel command line for x86
Date: Wed, 06 Aug 2008 17:52:13 -0500 [thread overview]
Message-ID: <1218063133.7576.16.camel@calx> (raw)
In-Reply-To: <489A2A24.6010400@zytor.com>
On Wed, 2008-08-06 at 15:48 -0700, H. Peter Anvin wrote:
> Tim Bird wrote:
> >
> > One difficulty is that the other arches' command lines
> > are not currently "broken", so there's no real incentive
> > to change them.
> >
> > The only thing novel thing I'm adding here is the addition of
> > the leading '!' to allow for an override. This is needed
> > in some x86 cases I'm familiar with, but I've haven't seen
> > any cases where it would be useful for other arches.
> > (not to say they don't exist - I just haven't seen them.)
> >
>
> Note that it could just as easily be done with a CONFIG_CMDLINE_OVERRIDE
> option, since the initial reason for a magic character was to be able to
> provide both prefix and suffix splicing.
You're right, I had forgotten about the suffix splicing and my brain is
a bit foggy on what motivated it.
> CONFIG_CMDLINE_OVERRIDE is probably more palatable to other architectures.
Yes, though I doubt we're in danger of introducing any real backwards
compatibility issues with the magic '!' at the beginning.
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2008-08-06 22:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 21:31 [PATCH] bootup: Add built-in kernel command line for x86 Tim Bird
2008-08-06 22:04 ` Robert Schwebel
2008-08-06 22:22 ` Tim Bird
2008-08-06 22:48 ` H. Peter Anvin
2008-08-06 22:52 ` Matt Mackall [this message]
2008-08-06 23:02 ` H. Peter Anvin
2008-08-06 23:00 ` Tim Bird
2008-08-06 23:03 ` H. Peter Anvin
2008-08-06 22:14 ` Matt Mackall
2008-08-06 22:31 ` Tim Bird
2008-08-06 22:48 ` Matt Mackall
2008-08-11 19:10 ` Ingo Molnar
2008-08-11 19:23 ` H. Peter Anvin
2008-08-11 22:40 ` Tim Bird
2008-08-12 19:52 ` [PATCH] bootup: Add built-in kernel command line for x86 (v2) Tim Bird
2008-08-15 14:03 ` Ingo Molnar
2008-08-15 14:12 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218063133.7576.16.camel@calx \
--to=mpm@selenic.com \
--cc=hpa@zytor.com \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=r.schwebel@pengutronix.de \
--cc=tglx@linutronix.de \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).