From: Daniel Walker <dwalker@fifo99.com>
To: Marco <marco.stornelli@gmail.com>
Cc: Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Linux Embedded <linux-embedded@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 08/14] Pramfs: Makefile and Kconfig
Date: Sat, 13 Jun 2009 07:02:12 -0700 [thread overview]
Message-ID: <1244901732.5982.221.camel@desktop> (raw)
In-Reply-To: <4A33A802.8040507@gmail.com>
On Sat, 2009-06-13 at 15:22 +0200, Marco wrote:
> From: Marco Stornelli <marco.stornelli@gmail.com>
>
> Makefile and Kconfig.
>
> Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
> ---
>
You should move this patch to 11 of 14, as I think that is the point
when the filesystem can actually be enabled and function. If this series
is only applied up to this patch you can get build failures if you
enabled PRAMFS, XIP, or any of the other features. Also breaking out the
individual features menuconfig options like XIP, and write protect, etc,
into their respective patches would be nice.
Daniel
next prev parent reply other threads:[~2009-06-13 14:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-13 13:22 [PATCH 08/14] Pramfs: Makefile and Kconfig Marco
2009-06-13 13:56 ` Sam Ravnborg
2009-06-14 7:15 ` Marco
2009-06-13 14:02 ` Daniel Walker [this message]
2009-06-14 7:16 ` Marco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244901732.5982.221.camel@desktop \
--to=dwalker@fifo99.com \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).