From: Marc Andre Tanner <mat@brain-dump.org>
To: linux-embedded@vger.kernel.org
Cc: mat@brain-dump.org
Subject: [RFC|PATCHv2] Compile time printk verbosity
Date: Wed, 2 Sep 2009 16:25:00 +0200 [thread overview]
Message-ID: <1251901505-4313-1-git-send-email-mat@brain-dump.org> (raw)
This series adds a configuration option to selectively compile out
printk message strings based on a verbosity level.
This works by wrapping printk with a macro which evaluates to a
constant if condition which the compiler will be able to optimize
out.
For situation were this filtering mechanism is not desired an
unfiltered variant is introduced: printk_unfiltered.
Currently the unfiltered variant is only used within
drivers/char/mem.c because we don't want to filter user space
data which comes is sent to /dev/kmsg.
Are there other places where the unfiltered variant should be used?
A known problem is that KERN_CONT messages aren't handled correctly.
The series was compile tested with make allyesconfig for x86 and
arm (with a cross compiler) but I might have missed something.
Thanks to Mike Frysinger and Jamie Lokier for their suggestions for
improvement.
All kinds of comments are welcome.
Marc Andre Tanner (5):
printk: introduce CONFIG_PRINTK_VERBOSITY
printk: move printk to the end of the file
printk: introduce printk_unfiltered as an alias to printk
char/mem: replace printk with printk_unfiltered
printk: provide a filtering macro for printk
drivers/char/mem.c | 2 +-
include/linux/kernel.h | 28 ++++++++++++++
init/Kconfig | 28 ++++++++++++++
kernel/printk.c | 95 ++++++++++++++++++++++++++++++------------------
4 files changed, 117 insertions(+), 36 deletions(-)
next reply other threads:[~2009-09-02 14:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 14:25 Marc Andre Tanner [this message]
2009-09-02 14:25 ` [PATCH 1/5] printk: introduce CONFIG_PRINTK_VERBOSITY Marc Andre Tanner
2009-09-02 16:44 ` Marco Stornelli
2009-09-02 17:32 ` Marc Andre Tanner
2009-09-02 14:25 ` [PATCH 2/5] printk: move printk to the end of the file Marc Andre Tanner
2009-09-02 14:25 ` [PATCH 3/5] printk: introduce printk_unfiltered as an alias to printk Marc Andre Tanner
2009-09-02 14:25 ` [PATCH 4/5] char/mem: replace printk with printk_unfiltered Marc Andre Tanner
2009-09-02 14:25 ` [PATCH 5/5] printk: provide a filtering macro for printk Marc Andre Tanner
2009-09-02 16:44 ` Marco Stornelli
2009-09-02 17:27 ` Marc Andre Tanner
2009-09-03 6:29 ` Marco Stornelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251901505-4313-1-git-send-email-mat@brain-dump.org \
--to=mat@brain-dump.org \
--cc=linux-embedded@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).