From: "Shargorodsky Atal (EXT-Teleca/Helsinki)" <ext-atal.shargorodsky@nokia.com>
To: ext David VomLehn <dvomlehn@cisco.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
"linux-embedded@vger.kernel.org" <linux-embedded@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"dwm2@infradead.org" <dwm2@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mpm@selenic.com" <mpm@selenic.com>
Subject: Re: [PATCH, RFC] panic-note: Annotation from user space for panics
Date: Fri, 13 Nov 2009 13:50:36 +0200 [thread overview]
Message-ID: <1258113036.5987.18.camel@atal-desktop> (raw)
In-Reply-To: <20091112220925.GC28349@dvomlehn-lnx2.corp.sa.net>
On Thu, 2009-11-12 at 23:09 +0100, ext David VomLehn wrote:
> On Thu, Nov 12, 2009 at 02:50:41PM -0500, Paul Gortmaker wrote:
> > David VomLehn wrote:
> >> Allows annotation of panics to include platform information. It's no big
> >> deal to collect information, but way helpful when you are collecting
> >> failure reports from a eventual base of millions of systems deployed in
> >> other people's homes.
> ...
> > Why hook into panic() directly like this, vs. using the panic
> > notifier list? If you use that, and then put the data handling
> > magic that you need into your own kernel module that knows how
> > to interface with the reporting apps that you have, you can
> > do the whole thing without having to alter existing code, I think.
>
> I agree--a panic notifier list is probably a better approach.
>
That's what we currently use:
http://marc.info/?l=linux-kernel&m=125655380512117&w=2
Very simple and does the job.
Requires to rearrange the panic code a bit, though.
Namely, to move notifiers invocation before the call to kmsg_dump().
Dumpers were introduced by Simon Kagstrom here:
http://marc.info/?l=linux-kernel&m=125569530109871&w=2
Regards,
Atal
> David VL
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2009-11-13 11:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 2:13 [PATCH, RFC] panic-note: Annotation from user space for panics David VomLehn
2009-11-12 18:00 ` Marco Stornelli
2009-11-12 21:56 ` David VomLehn
2009-11-13 8:10 ` Simon Kagstrom
2009-11-13 11:45 ` Artem Bityutskiy
2009-11-13 11:59 ` Simon Kagstrom
2009-11-13 14:16 ` Artem Bityutskiy
2009-11-14 8:28 ` Marco Stornelli
2009-11-17 8:53 ` Artem Bityutskiy
2009-11-17 12:45 ` Marco Stornelli
2009-11-17 13:10 ` Artem Bityutskiy
2009-11-17 15:45 ` Eric W. Biederman
2009-11-17 23:56 ` David VomLehn
2009-11-18 0:28 ` Eric W. Biederman
2009-11-18 0:53 ` David VomLehn
2009-11-18 9:01 ` Américo Wang
2009-11-18 17:01 ` Eric W. Biederman
2009-11-18 0:56 ` Matt Mackall
2009-11-18 16:07 ` Eric W. Biederman
2009-11-18 17:52 ` Tim Bird
2009-11-18 18:16 ` Eric W. Biederman
2009-11-18 8:26 ` Artem Bityutskiy
2009-11-17 17:53 ` Marco Stornelli
2009-11-12 18:06 ` Matt Mackall
2009-11-12 21:58 ` David VomLehn
2009-11-13 11:35 ` Artem Bityutskiy
2009-11-12 19:50 ` Paul Gortmaker
2009-11-12 22:09 ` David VomLehn
2009-11-13 11:50 ` Shargorodsky Atal (EXT-Teleca/Helsinki) [this message]
2009-11-13 11:26 ` Artem Bityutskiy
2009-11-17 9:03 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258113036.5987.18.camel@atal-desktop \
--to=ext-atal.shargorodsky@nokia.com \
--cc=akpm@linux-foundation.org \
--cc=dvomlehn@cisco.com \
--cc=dwm2@infradead.org \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).