From: Samo Pogacnik <samo_pogacnik@t-2.net>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-embedded <linux-embedded@vger.kernel.org>,
linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] detour TTY driver - now ttyprintk
Date: Sat, 26 Jun 2010 03:48:31 +0200 [thread overview]
Message-ID: <1277516912.29797.411.camel@itpsd6lap> (raw)
In-Reply-To: <20100625120329.1303aa61@lxorguk.ukuu.org.uk>
> > +static int tpk_write_room(struct tty_struct *tty)
> > +{
> > + int ret = tpk_space;
> > +
> > + /* allow char by char under max pressure */
> > + if (tpk_space == 0)
> > + tpk_space = 1;
>
> That won't do what you think, the ldisc will keep seeing progress and
> generate millions of 1 byte I/Os in a loop !
I thought that this would automatically reduce processor load, which is
obviously not the case. Sorry for the delay, but i am trying to figure
out how to slow down write method when under pressure.
And that setting tpk_space to 1 would then be just in case we reach 0 to
enable further processing.
Samo
next prev parent reply other threads:[~2010-06-26 1:48 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-15 10:17 [PATCH] detour TTY driver Samo Pogacnik
2010-05-29 22:17 ` Samo Pogacnik
2010-05-29 22:54 ` Alan Cox
2010-05-29 22:59 ` Al Viro
2010-05-29 23:33 ` Samo Pogacnik
2010-06-09 22:37 ` [PATCH] detour TTY driver - now ttyprintk Samo Pogacnik
2010-06-11 12:44 ` Alan Cox
2010-06-11 21:32 ` Samo Pogacnik
2010-06-21 14:38 ` Alan Cox
2010-06-22 22:06 ` Samo Pogacnik
2010-06-22 22:21 ` Alan Cox
2010-06-25 10:43 ` Samo Pogacnik
2010-06-25 11:03 ` Alan Cox
2010-06-26 1:48 ` Samo Pogacnik [this message]
2010-06-27 13:35 ` Alan Cox
2010-06-28 23:27 ` Samo Pogacnik
2010-07-03 19:21 ` Samo Pogacnik
2010-06-26 15:12 ` Samo Pogacnik
2010-08-24 20:03 ` Samo Pogacnik
2010-08-24 20:13 ` Greg KH
2010-08-24 20:57 ` Samo Pogacnik
2010-08-24 21:10 ` Greg KH
2010-08-24 22:09 ` Samo Pogacnik
2010-08-24 22:20 ` Greg KH
2010-08-24 22:50 ` Samo Pogacnik
2010-08-24 22:57 ` Greg KH
2010-08-24 23:22 ` Alan Cox
2010-08-24 23:12 ` Greg KH
2010-08-24 23:51 ` Alan Cox
2010-08-25 0:41 ` Greg KH
2010-08-25 6:50 ` Marco Stornelli
2010-08-25 10:08 ` Alan Cox
2010-08-25 15:57 ` Greg KH
2010-08-25 17:11 ` Alan Cox
2010-08-25 17:10 ` Greg KH
2010-08-25 18:14 ` Alan Cox
2010-08-25 18:16 ` Greg KH
2010-08-25 19:30 ` Alan Cox
2010-08-26 17:24 ` Samo Pogacnik
2010-08-26 23:02 ` Greg KH
2010-08-25 18:44 ` Samo Pogacnik
2010-09-01 22:50 ` patch "add ttyprintk driver" added to gregkh-2.6 tree gregkh
2010-08-25 7:40 ` [PATCH] detour TTY driver - now ttyprintk Kay Sievers
2010-08-25 7:48 ` Kay Sievers
2010-08-24 22:16 ` Alan Cox
2010-08-24 22:02 ` Greg KH
2010-06-11 23:31 ` Samo Pogacnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277516912.29797.411.camel@itpsd6lap \
--to=samo_pogacnik@t-2.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).