From: Matt Mackall <mpm@selenic.com>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-embedded@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] printk: add pr_<level>_once, guard print_hex_dump
Date: Mon, 06 Dec 2010 12:16:20 -0600 [thread overview]
Message-ID: <1291659380.3065.2214.camel@calx> (raw)
In-Reply-To: <1291659120.17494.179.camel@Joe-Laptop>
On Mon, 2010-12-06 at 10:12 -0800, Joe Perches wrote:
> On Mon, 2010-12-06 at 09:37 -0600, Matt Mackall wrote:
> > On Sun, 2010-12-05 at 21:44 -0800, Joe Perches wrote:
> > > There are many uses of printk_once(KERN_<level>.
> > > Add pr_<level>_once macros to avoid printk_once(KERN_<level> pr_fmt(fmt).
> > > Add an #ifdef CONFIG_PRINTK for print_hex_dump and static inline void
> > > functions for the #else cases to reduce embedded code size.
> > > Neaten and organize the rest of the code.
> > Looks fine to me. I'd missed the introduction of the pr_<level> macros
> > and I'm not sure if I like the idea, but this is a tidy and
> > well-presented cleanup and extension.
> > Acked-by: Matt Mackall <mpm@selenic.com>
>
> The #ifdef CONFIG_PRINTK guard for print_hex_dump saves ~200
> bytes in an x86 !CONFIG_PRINTK
>
> There could be ~500 bytes more saved if hex_dump_to_buffer
> was compiled out.
Can't say I'm excited by this approach. .5k is under my threshold for
this level of invasiveness.
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2010-12-06 18:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 5:44 [PATCH 0/7] printk: add pr_<level>_once, guard print_hex_dump Joe Perches
2010-12-06 5:44 ` [PATCH 1/7] include/linux/printk.h: Move console functions and variables together Joe Perches
2010-12-06 5:44 ` [PATCH 2/7] include/linux/printk.h: Use space after #define Joe Perches
2010-12-06 5:44 ` [PATCH 3/7] include/linux/printk.h: Use and neaten no_printk Joe Perches
2010-12-06 5:44 ` [PATCH 4/7] include/linux/printk.h: Add pr_<level>_once macros Joe Perches
2010-12-06 5:44 ` [PATCH 5/7] include/linux/printk.h lib/hexdump.c: Neatening and add CONFIG_PRINTK guard Joe Perches
2010-12-06 5:44 ` [PATCH 6/7] include/linux/printk.h: Organize printk_ratelimited macros Joe Perches
2010-12-06 5:44 ` [PATCH 7/7] include/linux/printk.h: Use tab not spaces for indent Joe Perches
2010-12-06 15:37 ` [PATCH 0/7] printk: add pr_<level>_once, guard print_hex_dump Matt Mackall
2010-12-06 18:12 ` Joe Perches
2010-12-06 18:16 ` Matt Mackall [this message]
2010-12-06 18:51 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291659380.3065.2214.camel@calx \
--to=mpm@selenic.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=joe@perches.com \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).