From: Marc Pignat <marc.pignat@hevs.ch>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: David Brownell <david-b@pacbell.net>,
Grant Likely <grant.likely@secretlab.ca>,
Paulius Zaleckas <paulius.zaleckas@teltonika.lt>,
netdev@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk,
linux-embedded@vger.kernel.org,
Laurent Pinchart <laurentp@cse-semaphore.com>
Subject: Re: [PATCH] phylib: make mdio-gpio work without OF (v2)
Date: Wed, 5 Nov 2008 09:57:25 +0100 [thread overview]
Message-ID: <200811050957.25821.marc.pignat@hevs.ch> (raw)
In-Reply-To: <8bd0f97a0811050032i206214a6r8d30a58f354995b4@mail.gmail.com>
On Wednesday 05 November 2008, Mike Frysinger wrote:
...
> i understand the compiler side just fine. my point is that the
> current linux/of_gpio.h only defines the OF structure and related
> prototypes when CONFIG_OF_GPIO is defined. so it needs updating
> first.
This is why I proposed to split the driver in two parts (gpio only mdio
driver + OF platform device). Just treating OF GPIO as any other GPIO.
This will remove all #ifdefs, the same code will be used for OF and non-OF
platforms and defining a platform device is not so complicated.
Best regards
Marc
next prev parent reply other threads:[~2008-11-05 8:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 14:45 [PATCH] phylib: make mdio-gpio work without OF (v2) Paulius Zaleckas
2008-11-04 15:45 ` Marc Pignat
2008-11-04 15:57 ` Grant Likely
2008-11-04 16:24 ` Grant Likely
2008-11-05 0:04 ` David Brownell
2008-11-05 0:09 ` Mike Frysinger
2008-11-05 4:45 ` David Brownell
2008-11-05 5:34 ` Mike Frysinger
2008-11-05 8:11 ` David Brownell
2008-11-05 8:32 ` Mike Frysinger
2008-11-05 8:57 ` Marc Pignat [this message]
2008-11-05 23:03 ` David Brownell
2008-11-05 8:57 ` Paulius Zaleckas
2008-11-05 9:04 ` Paulius Zaleckas
2008-11-05 15:04 ` Grant Likely
2008-11-05 22:59 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811050957.25821.marc.pignat@hevs.ch \
--to=marc.pignat@hevs.ch \
--cc=david-b@pacbell.net \
--cc=grant.likely@secretlab.ca \
--cc=laurentp@cse-semaphore.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-embedded@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulius.zaleckas@teltonika.lt \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).