Re: [PATCH] phylib: make mdio-gpio work without OF (v2)

[David Brownell <david-b@pacbell.net>]

On Wednesday 05 November 2008, Grant Likely wrote:
> > 	 Maybe the best solution is
> > to write separate driver for OF which will be just wrapper for platform
> > driver... Just like you suggested.

I'd certainly prefer that:  packaging all the OF glue in
a small bit of OF glue code, which doesn't need to affect
the majority of platforms (which don't and won't use OF).


> More complex than necessary.  Just give the driver 2 blocks of binding
> code; one for OF, one for non-OF.  No need to split up the driver.

The preceding discussion pointed out ways the "2 blocks"
approach doesn't currently work well ... minimally, there
is currently no way to do that without much ugly #ifdeffing.

And clearly, you and I view this a bit differently.  I'm
happier to think of these kinds of configuration as one
driver plus *separate* platform glue, while you want to be
modifying every driver to accomodate OF.  Or, by extension,
ACPI and any other hardware abstraction layer that comes
along.

- Dave