From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 1/6] lib/decompress_*: only include if STATIC is not defined Date: Tue, 4 Aug 2009 15:55:00 -0700 Message-ID: <20090804155500.db6c88fa.akpm@linux-foundation.org> References: <20090731093107.GA29704@merkur.ravnborg.org> <1249311501-23102-1-git-send-email-albin.tonnerre@free-electrons.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1249311501-23102-1-git-send-email-albin.tonnerre@free-electrons.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Cc: sam@ravnborg.org, hpa@zytor.com, linux@arm.linux.org.uk, alain@knaff.lu, linux-kernel@vger.kernel.org, linux-embedded@vger.kernel.org, albin.tonnerre@free-electrons.com, Phillip Lougher On Mon, 3 Aug 2009 16:58:16 +0200 Albin Tonnerre wrote: > These includes were added by 079effb6933f34b9b1b67b08bd4fd7fb672d16ef to > fix the build when using kmemtrace. However this is not necessary when > used to create a compressed kernel, and actually creates issues (brings > a lot of things unavailable in the decompression environment), so don't > include it if STATIC is defined. > The description "actually creates issues (brings a lot of things unavailable in the decompression environment)" is inadequate. Please describe te problem this patch fixes more completely so that others (ie: me) can decide whether this patch is needed in 2.6.32, 2.6.31. 2.6.30, ... This patch conflicts heavily with http://userweb.kernel.org/~akpm/mmotm/broken-out/bzip2-lzma-remove-nasty-uncompressed-size-hack-in-pre-boot-environment.patch What should we do about that?