From: Marc Andre Tanner <mat@brain-dump.org>
To: Marco Stornelli <marco.stornelli@gmail.com>
Cc: linux-embedded@vger.kernel.org
Subject: Re: [PATCH 5/5] printk: provide a filtering macro for printk
Date: Wed, 2 Sep 2009 19:27:24 +0200 [thread overview]
Message-ID: <20090902172724.GA5811@debbook.brain-dump.org> (raw)
In-Reply-To: <4A9EA0E3.8000603@gmail.com>
On Wed, Sep 02, 2009 at 06:44:19PM +0200, Marco Stornelli wrote:
>
>
> Marc Andre Tanner ha scritto:
> > +#define printk(fmt, ...) ( \
>
> Shouldn't it be an and?
Don't think so. If the expression isn't constant we are unable to filter it
and therefore printk is called anyway. However if the expression is constant
the second part of the condition is evaluated and we filter based on the
verbosity level.
> > + (!__builtin_constant_p(PRINTK_FILTER((fmt))) || PRINTK_FILTER((fmt))) ? \
> > + printk((fmt), ##__VA_ARGS__) : 0 \
> > +)
> > +
> > +#endif /* CONFIG_PRINTK_VERBOSITY */
> > +
Marc
--
Marc Andre Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0
next prev parent reply other threads:[~2009-09-02 17:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 14:25 [RFC|PATCHv2] Compile time printk verbosity Marc Andre Tanner
2009-09-02 14:25 ` [PATCH 1/5] printk: introduce CONFIG_PRINTK_VERBOSITY Marc Andre Tanner
2009-09-02 16:44 ` Marco Stornelli
2009-09-02 17:32 ` Marc Andre Tanner
2009-09-02 14:25 ` [PATCH 2/5] printk: move printk to the end of the file Marc Andre Tanner
2009-09-02 14:25 ` [PATCH 3/5] printk: introduce printk_unfiltered as an alias to printk Marc Andre Tanner
2009-09-02 14:25 ` [PATCH 4/5] char/mem: replace printk with printk_unfiltered Marc Andre Tanner
2009-09-02 14:25 ` [PATCH 5/5] printk: provide a filtering macro for printk Marc Andre Tanner
2009-09-02 16:44 ` Marco Stornelli
2009-09-02 17:27 ` Marc Andre Tanner [this message]
2009-09-03 6:29 ` Marco Stornelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090902172724.GA5811@debbook.brain-dump.org \
--to=mat@brain-dump.org \
--cc=linux-embedded@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).