From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [RFC] misc/at24: add experimental OF support for the generic eeprom driver Date: Fri, 9 Oct 2009 18:20:20 +0200 Message-ID: <20091009162020.GB588@pengutronix.de> References: <1255010672-21656-1-git-send-email-w.sang@pengutronix.de> <20091008143301.GA6084@oksana.dev.rtsoft.ru> <20091008151007.GA21328@oksana.dev.rtsoft.ru> <20091008202723.GA8116@pengutronix.de> <20091009051409.GA2361@pengutronix.de> <1255096871.16018.49.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2956660571441688445==" Return-path: In-Reply-To: <1255096871.16018.49.camel@localhost.localdomain> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org To: Nate Case Cc: devicetree-discuss@ozlabs.org, linux-embedded@vger.kernel.org, linuxppc-dev@ozlabs.org, linux-i2c@vger.kernel.org --===============2956660571441688445== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="b5gNqxB1S1yM7hjW" Content-Disposition: inline --b5gNqxB1S1yM7hjW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > I can submit that soon, but it probably makes sense for Wolfram to > voice whatever his concerns were about "questionable" properties before > I document what's there. Please don't feel offended. The things I noticed are: a) no documentation b) 'polarity' is a direct mapping to the register which IMO is a hint to lo= ok closer. I haven't checked in detil, but maybe the active_low-flag could be = used for this? I mainly got alarmed that properties were mainlined without being reviewed;= as the device-tree is based on convention (which is hard to change afterwards)= , I try to make sure this will not so easily happen again (thus the get_maintainer-patch on lkml). Regards, Wolfram --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --b5gNqxB1S1yM7hjW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkrPYsQACgkQD27XaX1/VRvaWgCgvUNhJqjS+Ukr6FpnNyea2kOe ng8An12HR1WAnkJJd43Fyf4VDUcvM5Wl =YsSA -----END PGP SIGNATURE----- --b5gNqxB1S1yM7hjW-- --===============2956660571441688445== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev --===============2956660571441688445==--