From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [RFC/PATCH 0/2] u_char.c and mtp.c patches Date: Mon, 19 Apr 2010 23:04:57 +0300 Message-ID: <20100419200457.GB27643@nokia.com> References: <1268123742-22968-1-git-send-email-felipe.balbi@nokia.com> <20100419162611.GA15131@nokia.com> <20100419171534.GA30381@kroah.com> <20100419172404.GA15340@nokia.com> Reply-To: felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="utf-8"; format="flowed" To: ext =?utf-8?Q?Micha=C5=82?= Nazarewicz Cc: "Balbi Felipe (Nokia-D/Helsinki)" , ext Greg KH , ext Linus Walleij , Linux USB Mailing List , "Krogerus Heikki (EXT-Teleca/Helsinki)" , "Quadros Roger (Nokia-D/Helsinki)" , "Kaliuta Yauheni (Nokia-D/Helsinki)" , "Mandy Arnaud.2 (EXT-Teleca/Helsinki)" , David Brownell , linux-embedded , Tim Bird , "libmtp-discuss-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , =?utf-8?Q?Micha=C5=82?= Nazarewicz On Mon, Apr 19, 2010 at 08:57:18PM +0200, ext Micha=C5=82 Nazarewicz wr= ote: >>> On Mon, Apr 19, 2010 at 06:55:53PM +0200, Micha=C5=82 Nazarewicz wr= ote: >>>> On related news, I've just posted FunctionFS driver. :) It's still= imperfect >>>> but appears to be working. > >> On Mon, Apr 19, 2010 at 07:15:34PM +0200, ext Greg KH wrote: >>> Yes, that should solve the gadgetfs issue for you, right Felipe? > >On Mon, 19 Apr 2010 19:24:04 +0200, Felipe Balbi wrote: >> sure it should. Will take a look at it :-) > >As I've said it's still imperfect. In particular the throughput won't= be >impressive but that's on the TODO list (I first want to put a real dri= ver yeah, I saw that you allocate the memory whenever you get=20 read()/write(). That's a good choice IMO. It would be nice if you would= =20 have a vmalloc()ed kfifo instead and use that a ring buffer. Then you=20 unload in smaller chunks. >on top of FunctionFS before optimising the code) and in particular u_c= har >seem to be a good piece to steal code from. ;) Still, as said, I have= n't >analysed possible optimisations just yet. go for it :-) It's free software anyways :-D --=20 balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html