From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Linus WALLEIJ <linus.walleij@stericsson.com>
Cc: Greg KH <gregkh@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
David Brownell <dbrownell@users.sourceforge.net>,
Russell King <linux@arm.linux.org.uk>,
"linux-embedded@vger.kernel.org" <linux-embedded@vger.kernel.org>,
Viresh KUMAR <viresh.kumar@st.com>
Subject: Re: [PATCH] RFC: AMBA bus discardable probe() function
Date: Wed, 4 Aug 2010 23:43:26 -0700 [thread overview]
Message-ID: <201008042343.27043.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <CEE6BB42CAD6E947908279175AF8470A0262E58F8B@EXDCVYMBSTM006.EQ1STM.local>
On Wednesday, August 04, 2010 11:26:00 pm Linus WALLEIJ wrote:
> [Greg]
>
> > [Me]
> >
> > > + spin_lock(&amba_bustype.p->klist_drivers.k_lock);
> >
> > Ick, nope, you can't do this, sorry. That's a "private" structure for
> > a reason.
>
> Yeah I get it, but in the platform bus case what's that traversal of
> the klists actually for? I didn't get it, and was guessing that it
> was considering the case where devices spawn new devices.
It is to check if the driver actually bound to any devices and fail driver
registration if it did not - then, in case of modular build, entire driver
module might get unloaded from memory as well.
--
Dmitry
prev parent reply other threads:[~2010-08-05 6:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1280925543-6862-1-git-send-email-linus.walleij@stericsson.com>
[not found] ` <20100804222410.GB12502@n2100.arm.linux.org.uk>
2010-08-05 6:22 ` [PATCH] RFC: AMBA bus discardable probe() function Linus WALLEIJ
[not found] ` <20100804194319.GA30722@suse.de>
2010-08-05 6:26 ` Linus WALLEIJ
2010-08-05 6:43 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008042343.27043.dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=dbrownell@users.sourceforge.net \
--cc=gregkh@suse.de \
--cc=linus.walleij@stericsson.com \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=viresh.kumar@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).