linux-embedded.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 15/16] pramfs: test module
@ 2010-10-10 16:37 Marco Stornelli
  2010-10-10 16:57 ` Randy Dunlap
  2010-10-11 12:24 ` Kieran Bingham
  0 siblings, 2 replies; 5+ messages in thread
From: Marco Stornelli @ 2010-10-10 16:37 UTC (permalink / raw)
  To: Linux Kernel; +Cc: Linux Embedded, Linux FS Devel, Tim Bird

From: Marco Stornelli <marco.stornelli@gmail.com>

Test module.

Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
---
diff -Nurp linux-2.6.36-orig/fs/pramfs/pramfs_test.c linux-2.6.36/fs/pramfs/pramfs_test.c
--- linux-2.6.36-orig/fs/pramfs/pramfs_test.c	1970-01-01 01:00:00.000000000 +0100
+++ linux-2.6.36/fs/pramfs/pramfs_test.c	2010-09-14 18:49:52.000000000 +0200
@@ -0,0 +1,49 @@
+/*
+ * FILE NAME fs/pramfs/namei.c
+ *
+ * BRIEF DESCRIPTION
+ *
+ * Pramfs test module.
+ *
+ * Copyright 2009-2010 Marco Stornelli <marco.stornelli@gmail.com>
+ * Copyright 2003 Sony Corporation
+ * Copyright 2003 Matsushita Electric Industrial Co., Ltd.
+ * 2003-2004 (c) MontaVista Software, Inc. , Steve Longerbeam
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+#include <linux/module.h>
+#include <linux/version.h>
+#include <linux/init.h>
+#include <linux/fs.h>
+#include "pram.h"
+
+int __init test_pramfs_write(void)
+{
+	struct pram_super_block *psb;
+
+	psb = get_pram_super();
+	if (!psb) {
+		printk(KERN_ERR
+		"%s: PRAMFS super block not found (not mounted?)\n",
+		__func__);
+		return 1;
+	}
+
+	/*
+	 * Attempt an unprotected clear of checksum information in the
+	 * superblock, this should cause a kernel page protection fault.
+	 */
+	printk("%s: writing to kernel VA %p\n", __func__, psb);
+	psb->s_sum = 0;
+
+	return 0;
+}
+
+void test_pramfs_write_cleanup(void) {}
+
+/* Module information */
+MODULE_LICENSE("GPL");
+module_init(test_pramfs_write);
+module_exit(test_pramfs_write_cleanup);
 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 15/16] pramfs: test module
  2010-10-10 16:37 [PATCH 15/16] pramfs: test module Marco Stornelli
@ 2010-10-10 16:57 ` Randy Dunlap
  2010-10-11  7:08   ` Marco Stornelli
  2010-10-11 12:24 ` Kieran Bingham
  1 sibling, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2010-10-10 16:57 UTC (permalink / raw)
  To: Marco Stornelli; +Cc: Linux Kernel, Linux Embedded, Linux FS Devel, Tim Bird

On Sun, 10 Oct 2010 18:37:49 +0200 Marco Stornelli wrote:

> From: Marco Stornelli <marco.stornelli@gmail.com>
> 
> Test module.
> 
> Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
> ---
> diff -Nurp linux-2.6.36-orig/fs/pramfs/pramfs_test.c linux-2.6.36/fs/pramfs/pramfs_test.c
> --- linux-2.6.36-orig/fs/pramfs/pramfs_test.c	1970-01-01 01:00:00.000000000 +0100
> +++ linux-2.6.36/fs/pramfs/pramfs_test.c	2010-09-14 18:49:52.000000000 +0200
> @@ -0,0 +1,49 @@
> +/*
> + * FILE NAME fs/pramfs/namei.c
> + *
> + * BRIEF DESCRIPTION
> + *
> + * Pramfs test module.
> + *
> + * Copyright 2009-2010 Marco Stornelli <marco.stornelli@gmail.com>
> + * Copyright 2003 Sony Corporation
> + * Copyright 2003 Matsushita Electric Industrial Co., Ltd.
> + * 2003-2004 (c) MontaVista Software, Inc. , Steve Longerbeam
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
> + */
> +#include <linux/module.h>
> +#include <linux/version.h>
> +#include <linux/init.h>
> +#include <linux/fs.h>
> +#include "pram.h"
> +
> +int __init test_pramfs_write(void)
> +{
> +	struct pram_super_block *psb;
> +
> +	psb = get_pram_super();
> +	if (!psb) {
> +		printk(KERN_ERR
> +		"%s: PRAMFS super block not found (not mounted?)\n",
> +		__func__);

Above 2 lines need to indented more.

> +		return 1;
> +	}
> +
> +	/*
> +	 * Attempt an unprotected clear of checksum information in the
> +	 * superblock, this should cause a kernel page protection fault.
> +	 */
> +	printk("%s: writing to kernel VA %p\n", __func__, psb);
> +	psb->s_sum = 0;
> +
> +	return 0;
> +}
> +
> +void test_pramfs_write_cleanup(void) {}
> +
> +/* Module information */
> +MODULE_LICENSE("GPL");
> +module_init(test_pramfs_write);
> +module_exit(test_pramfs_write_cleanup);


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 15/16] pramfs: test module
  2010-10-10 16:57 ` Randy Dunlap
@ 2010-10-11  7:08   ` Marco Stornelli
  0 siblings, 0 replies; 5+ messages in thread
From: Marco Stornelli @ 2010-10-11  7:08 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: Linux Kernel, Linux Embedded, Linux FS Devel, Tim Bird

2010/10/10 Randy Dunlap <rdunlap@xenotime.net>:
> On Sun, 10 Oct 2010 18:37:49 +0200 Marco Stornelli wrote:
>
> Above 2 lines need to indented more.
>

Ack.

>> +             return 1;
>> +     }
>> +
>> +     /*
>> +      * Attempt an unprotected clear of checksum information in the
>> +      * superblock, this should cause a kernel page protection fault.
>> +      */
>> +     printk("%s: writing to kernel VA %p\n", __func__, psb);
>> +     psb->s_sum = 0;
>> +
>> +     return 0;
>> +}
>> +
>> +void test_pramfs_write_cleanup(void) {}
>> +
>> +/* Module information */
>> +MODULE_LICENSE("GPL");
>> +module_init(test_pramfs_write);
>> +module_exit(test_pramfs_write_cleanup);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 15/16] pramfs: test module
  2010-10-10 16:37 [PATCH 15/16] pramfs: test module Marco Stornelli
  2010-10-10 16:57 ` Randy Dunlap
@ 2010-10-11 12:24 ` Kieran Bingham
  2010-10-13 11:23   ` Christoph Hellwig
  1 sibling, 1 reply; 5+ messages in thread
From: Kieran Bingham @ 2010-10-11 12:24 UTC (permalink / raw)
  To: Marco Stornelli; +Cc: Linux Kernel, Linux Embedded, Linux FS Devel, Tim Bird

  On 10/10/2010 17:37, Marco Stornelli wrote:
> From: Marco Stornelli<marco.stornelli@gmail.com>
>
> Test module.
>
> Signed-off-by: Marco Stornelli<marco.stornelli@gmail.com>
> ---
> diff -Nurp linux-2.6.36-orig/fs/pramfs/pramfs_test.c linux-2.6.36/fs/pramfs/pramfs_test.c
> --- linux-2.6.36-orig/fs/pramfs/pramfs_test.c	1970-01-01 01:00:00.000000000 +0100
> +++ linux-2.6.36/fs/pramfs/pramfs_test.c	2010-09-14 18:49:52.000000000 +0200
> @@ -0,0 +1,49 @@
> +/*
> + * FILE NAME fs/pramfs/namei.c
FILE NAME != namei.c

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 15/16] pramfs: test module
  2010-10-11 12:24 ` Kieran Bingham
@ 2010-10-13 11:23   ` Christoph Hellwig
  0 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2010-10-13 11:23 UTC (permalink / raw)
  To: Kieran Bingham
  Cc: Marco Stornelli, Linux Kernel, Linux Embedded, Linux FS Devel,
	Tim Bird

On Mon, Oct 11, 2010 at 01:24:04PM +0100, Kieran Bingham wrote:
> >@@ -0,0 +1,49 @@
> >+/*
> >+ * FILE NAME fs/pramfs/namei.c
> FILE NAME != namei.c

Yes, that's why you should never do such filename comments which are not
only utterly prone to be out of data, but also 100% useless.


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2010-10-13 11:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-10 16:37 [PATCH 15/16] pramfs: test module Marco Stornelli
2010-10-10 16:57 ` Randy Dunlap
2010-10-11  7:08   ` Marco Stornelli
2010-10-11 12:24 ` Kieran Bingham
2010-10-13 11:23   ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).