From: Grant Likely <grant.likely@secretlab.ca>
To: Bill Gatliff <bgat@billgatliff.com>
Cc: linux-embedded@vger.kernel.org
Subject: Re: [PWM 06/10] Incorporate PWM API code into KBuild
Date: Sat, 16 Oct 2010 02:02:07 -0600 [thread overview]
Message-ID: <20101016080207.GG653@angua.secretlab.ca> (raw)
In-Reply-To: <1285946271-17728-6-git-send-email-bgat@billgatliff.com>
On Fri, Oct 01, 2010 at 10:17:47AM -0500, Bill Gatliff wrote:
> Signed-off-by: Bill Gatliff <bgat@billgatliff.com>
Ditto on description.
> ---
> drivers/Kconfig | 2 ++
> drivers/Makefile | 2 ++
> drivers/leds/Kconfig | 22 ++++++++++++++++------
> drivers/leds/Makefile | 2 ++
> drivers/pwm/Kconfig | 28 ++++++++++++++++++++++++++++
> drivers/pwm/Makefile | 6 ++++++
> 6 files changed, 56 insertions(+), 6 deletions(-)
> create mode 100644 drivers/pwm/Kconfig
> create mode 100644 drivers/pwm/Makefile
Hmmm... is this patch series bisectable?
>
> diff --git a/drivers/Kconfig b/drivers/Kconfig
> index a2b902f..60390cb 100644
> --- a/drivers/Kconfig
> +++ b/drivers/Kconfig
> @@ -54,6 +54,8 @@ source "drivers/pps/Kconfig"
>
> source "drivers/gpio/Kconfig"
>
> +source "drivers/pwm/Kconfig"
> +
> source "drivers/w1/Kconfig"
>
> source "drivers/power/Kconfig"
> diff --git a/drivers/Makefile b/drivers/Makefile
> index a2aea53..fa7ca1c 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -6,6 +6,8 @@
> #
>
> obj-y += gpio/
> +obj-$(CONFIG_GENERIC_PWM) += pwm/
> +
> obj-$(CONFIG_PCI) += pci/
> obj-$(CONFIG_PARISC) += parisc/
> obj-$(CONFIG_RAPIDIO) += rapidio/
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index 3af2cde..b434fa3 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -249,12 +249,6 @@ config LEDS_DAC124S085
> This option enables support for DAC124S085 SPI DAC from NatSemi,
> which can be used to control up to four LEDs.
>
> -config LEDS_PWM
> - tristate "PWM driven LED Support"
> - depends on HAVE_PWM
> - help
> - This option enables support for pwm driven LEDs
> -
> config LEDS_REGULATOR
> tristate "REGULATOR driven LED support"
> depends on REGULATOR
> @@ -354,6 +348,14 @@ config LEDS_TRIGGER_HEARTBEAT
> load average.
> If unsure, say Y.
>
> +config LEDS_TRIGGER_DIM
> + tristate "LED Dimmer Trigger"
> + depends on LEDS_TRIGGERS
> + help
> + Regulates the brightness of an LED based on the 1-minute CPU
> + load average. Ideal for PWM-driven LEDs.
> + If unsure, say Y.
> +
> config LEDS_TRIGGER_BACKLIGHT
> tristate "LED backlight Trigger"
> help
> @@ -374,6 +376,14 @@ config LEDS_TRIGGER_GPIO
>
> If unsure, say N.
>
> +config LEDS_TRIGGER_DIM
> + tristate "LED Dimmer Trigger"
> + depends on LEDS_TRIGGERS
> + help
> + Regulates the brightness of an LED based on the 1-minute CPU
> + load average. Ideal for PWM-driven LEDs.
> + If unsure, say Y.
> +
Inconsistent whitespace
> config LEDS_TRIGGER_DEFAULT_ON
> tristate "LED Default ON Trigger"
> help
> diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile
> index 7d6b958..a4ccea4 100644
> --- a/drivers/leds/Makefile
> +++ b/drivers/leds/Makefile
> @@ -22,6 +22,7 @@ obj-$(CONFIG_LEDS_COBALT_RAQ) += leds-cobalt-raq.o
> obj-$(CONFIG_LEDS_SUNFIRE) += leds-sunfire.o
> obj-$(CONFIG_LEDS_PCA9532) += leds-pca9532.o
> obj-$(CONFIG_LEDS_GPIO) += leds-gpio.o
> +obj-$(CONFIG_LEDS_PWM) += leds-pwm.o
> obj-$(CONFIG_LEDS_LP3944) += leds-lp3944.o
> obj-$(CONFIG_LEDS_CLEVO_MAIL) += leds-clevo-mail.o
> obj-$(CONFIG_LEDS_HP6XX) += leds-hp6xx.o
> @@ -46,6 +47,7 @@ obj-$(CONFIG_LEDS_DAC124S085) += leds-dac124s085.o
> obj-$(CONFIG_LEDS_TRIGGER_TIMER) += ledtrig-timer.o
> obj-$(CONFIG_LEDS_TRIGGER_IDE_DISK) += ledtrig-ide-disk.o
> obj-$(CONFIG_LEDS_TRIGGER_HEARTBEAT) += ledtrig-heartbeat.o
> +obj-$(CONFIG_LEDS_TRIGGER_DIM) += ledtrig-dim.o
> obj-$(CONFIG_LEDS_TRIGGER_BACKLIGHT) += ledtrig-backlight.o
> obj-$(CONFIG_LEDS_TRIGGER_GPIO) += ledtrig-gpio.o
> obj-$(CONFIG_LEDS_TRIGGER_DEFAULT_ON) += ledtrig-default-on.o
> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> new file mode 100644
> index 0000000..0584c25
> --- /dev/null
> +++ b/drivers/pwm/Kconfig
> @@ -0,0 +1,28 @@
> +#
> +# PWM infrastructure and devices
> +#
> +
> +menuconfig GENERIC_PWM
> + tristate "PWM Support"
> + depends on SYSFS
> + help
> + This enables PWM support through the generic PWM API.
> + If unsure, say N.
> +
> +if GENERIC_PWM
> +
> +config ATMEL_PWM
> + tristate "Atmel AT32/AT91 PWM support"
> + depends on AVR32 || ARCH_AT91
> + help
> + This option enables device driver support for the PWMC
> + peripheral channels found on certain Atmel processors.
> + If unsure, say N.
> +
> +config GPIO_PWM
> + tristate "PWM emulation using GPIO"
> + help
> + This option enables a single-channel PWM device using
Ditto
> + a kernel interval timer and a GPIO pin. If unsure, say N.
> +
> +endif
> diff --git a/drivers/pwm/Makefile b/drivers/pwm/Makefile
> new file mode 100644
> index 0000000..e8cacc5
> --- /dev/null
> +++ b/drivers/pwm/Makefile
> @@ -0,0 +1,6 @@
> +#
> +# Makefile for pwm devices
> +#
> +obj-y := pwm.o
> +obj-$(CONFIG_ATMEL_PWM) += atmel-pwm.o
> +obj-$(CONFIG_GPIO_PWM) += gpio.o
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-embedded" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-10-16 8:02 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 15:17 [PWM 01/10] API to consolidate PWM devices behind a common user and kernel interface Bill Gatliff
2010-10-01 15:17 ` [PWM 02/10] Emulates PWM hardware using a high-resolution timer and a GPIO pin Bill Gatliff
2010-10-16 6:54 ` Grant Likely
2010-10-01 15:17 ` [PWM 03/10] Expunge old Atmel PWMC driver, replacing it with one that conforms to the PWM API Bill Gatliff
2010-10-16 7:50 ` Grant Likely
2010-10-01 15:17 ` [PWM 04/10] Implements PWM-based LED control Bill Gatliff
2010-10-16 7:58 ` Grant Likely
2010-10-01 15:17 ` [PWM 05/10] LED "dim" trigger based on PWM control of the LED Bill Gatliff
2010-10-16 8:00 ` Grant Likely
2010-10-01 15:17 ` [PWM 06/10] Incorporate PWM API code into KBuild Bill Gatliff
2010-10-16 8:02 ` Grant Likely [this message]
2010-10-19 2:17 ` Bill Gatliff
2010-10-01 15:17 ` [PWM 07/10] PWM API driver for MPC52xx GPT peripheral Bill Gatliff
2010-10-01 15:17 ` [PWM 08/10] Initial support for PXA PWM peripheral; compile-tested only Bill Gatliff
2010-10-01 15:17 ` Bill Gatliff
2010-10-01 15:17 ` [PWM 09/10] Build pwm.o only if CONFIG_GENERIC_PWM is set Bill Gatliff
2010-10-01 15:17 ` [PWM 10/10] Expunge previous driver for PXA PWM Bill Gatliff
2010-10-01 22:00 ` [PWM 01/10] API to consolidate PWM devices behind a common user and kernel interface Kevin Hilman
2010-10-02 5:13 ` Jason Kridner
2010-10-06 18:45 ` Bill Gatliff
2010-10-06 19:08 ` Kevin Hilman
2010-10-02 12:25 ` Hector Oron
2010-10-06 18:48 ` Bill Gatliff
2010-10-16 6:05 ` Grant Likely
2010-10-05 10:35 ` sugumar
2010-10-06 18:50 ` Bill Gatliff
2010-10-06 19:02 ` Grosen, Mark
2010-10-07 7:58 ` Sugumar Natarajan
2010-10-16 7:42 ` Grant Likely
2010-10-20 18:13 ` Bill Gatliff
2010-10-20 18:34 ` Grant Likely
2010-10-20 19:32 ` Bill Gatliff
2010-10-21 13:18 ` Bill Gatliff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101016080207.GG653@angua.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=bgat@billgatliff.com \
--cc=linux-embedded@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).