From: Ingo Molnar <mingo@elte.hu>
To: "Rafael J. Wysocki" <rjw@sisk.pl>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Len Brown <len.brown@intel.com>,
Alan Stern <stern@rowland.harvard.edu>,
linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-embedded@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] Remove CONFIG_PM altogether, enable power management all the time
Date: Tue, 8 Feb 2011 13:21:59 +0100 [thread overview]
Message-ID: <20110208122159.GA8284@elte.hu> (raw)
In-Reply-To: <201102072215.59921.rjw@sisk.pl>
* Rafael J. Wysocki <rjw@sisk.pl> wrote:
> I'd appreciate it if people could review/test it and drop their comments.
>
> Thanks,
> Rafael
>
> ---
> arch/x86/xen/Kconfig | 2 +-
> drivers/acpi/Kconfig | 1 -
> drivers/acpi/bus.c | 4 +---
> drivers/acpi/internal.h | 6 ++++++
> drivers/acpi/sleep.c | 13 +++++++++++--
> drivers/base/power/Makefile | 3 +--
> drivers/net/e1000e/netdev.c | 8 ++++----
> drivers/net/pch_gbe/pch_gbe_main.c | 2 +-
> drivers/pci/pci-driver.c | 4 ++--
> drivers/scsi/Makefile | 2 +-
> drivers/scsi/scsi_priv.h | 2 +-
> drivers/scsi/scsi_sysfs.c | 2 +-
> drivers/usb/core/hcd-pci.c | 4 ++--
> include/acpi/acpi_bus.h | 2 +-
> include/linux/pm.h | 2 +-
> kernel/power/Kconfig | 29 +++--------------------------
> 16 files changed, 37 insertions(+), 49 deletions(-)
Ok, there's some real bang for bucks in this patch, nice! It's a beginning.
Reviewed-by: Ingo Molnar <mingo@elte.hu>
Also, i've Cc:-ed Linus, to check whether the idea to make power management a
permanent, core portion of Linux has any obvious downsides we missed.
Rafael, could you do a defconfig-ish x86 build with and without CONFIG_PM, and post
the 'size vmlinux' comparison - so that we can see the size difference? We make some
things CONFIG_EXPERT configurable just to enable folks who *really* want to cut down
on kernel size to configure it out.
Note that those usecases, even if they want a super-small kernel, might not care
about PM at all while they care about size: small boot kernels in ROMs, or simple
devices where CPU-idling implies deep low power mode, etc.
So the vmlinux size comparisons would be needed really. If it's 5k nobody will care.
If it's 50k-100k that's borderline. In the other side of the scale we have the 1500+
#ifdef CONFIG_PM lines strewn around the kernel source, and the frequent !PM build
breakages.
Ingo
next prev parent reply other threads:[~2011-02-08 12:21 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 12:22 [PATCH] PM: Hide CONFIG_PM from users Mark Brown
2011-02-07 12:40 ` Geert Uytterhoeven
2011-02-07 13:26 ` Mark Brown
2011-02-07 12:48 ` Ingo Molnar
2011-02-07 13:09 ` Mark Brown
2011-02-07 14:13 ` Stephen Rothwell
2011-02-07 14:18 ` Mark Brown
2011-02-07 14:44 ` Stephen Rothwell
2011-02-07 14:50 ` Mark Brown
2011-02-07 15:00 ` Geert Uytterhoeven
2011-02-07 15:10 ` Stephen Rothwell
2011-02-07 15:19 ` Stephen Rothwell
2011-02-07 15:21 ` Mark Brown
2011-02-07 15:36 ` Alan Stern
2011-02-07 15:49 ` Mark Brown
2011-02-07 19:16 ` Rafael J. Wysocki
2011-02-08 1:17 ` Ray Lee
2011-02-08 11:18 ` Mark Brown
2011-02-07 19:14 ` Rafael J. Wysocki
2011-02-07 19:30 ` Mark Brown
2011-02-07 19:46 ` Rafael J. Wysocki
2011-02-07 20:18 ` Mark Brown
2011-02-07 21:15 ` Rafael J. Wysocki
2011-02-07 21:47 ` Dmitry Torokhov
2011-02-07 22:00 ` Rafael J. Wysocki
2011-02-07 22:23 ` Dmitry Torokhov
2011-02-07 23:05 ` Rafael J. Wysocki
2011-02-08 0:50 ` Dmitry Torokhov
2011-02-08 9:23 ` Rafael J. Wysocki
2011-02-08 16:48 ` Paul Mundt
2011-02-08 12:12 ` Mark Brown
2011-02-08 12:21 ` Ingo Molnar [this message]
2011-02-08 21:18 ` [PATCH 0/5] Re: Remove CONFIG_PM altogether, enable power management all the time Rafael J. Wysocki
2011-02-08 21:20 ` [PATCH 1/5] ACPI / PM: Move references to pm_flags into sleep.c Rafael J. Wysocki
2011-02-08 23:40 ` Linus Torvalds
2011-02-09 0:37 ` Rafael J. Wysocki
2011-02-09 1:04 ` Linus Torvalds
2011-02-08 21:21 ` [PATCH 2/5] PM: Make CONFIG_PM depend on (CONFIG_PM_SLEEP || CONFIG_PM_RUNTIME) Rafael J. Wysocki
2011-02-08 21:21 ` [PATCH 3/5] PM: Reorder power management Kconfig options Rafael J. Wysocki
2011-02-08 21:22 ` [PATCH 4/5] PM: Replace CONFIG_PM_OPS with CONFIG_PM Rafael J. Wysocki
2011-02-08 21:23 ` [PATCH 5/5] PM: Clean up Kconfig dependencies Rafael J. Wysocki
2011-02-08 23:43 ` Linus Torvalds
2011-02-10 23:32 ` [Updated][PATCH 5/5] PM: Clean up PM_TRACE dependencies and drop unnecessary Kconfig option Rafael J. Wysocki
2011-02-08 23:35 ` [PATCH] Remove CONFIG_PM altogether, enable power management all the time Frank Rowand
2011-02-09 11:41 ` Mark Brown
2011-02-09 11:58 ` Mark Brown
2011-02-09 17:07 ` Rafael J. Wysocki
2011-02-09 18:31 ` Frank Rowand
2011-02-09 18:40 ` Mark Brown
2011-02-09 19:00 ` Frank Rowand
2011-02-09 19:25 ` Mark Brown
2011-02-09 19:53 ` Tim Bird
2011-02-09 19:59 ` Mark Brown
2011-02-09 20:09 ` Alan Stern
2011-02-09 20:10 ` Mark Brown
2011-02-08 23:35 ` Tim Bird
2011-02-09 2:41 ` Ingo Molnar
2011-02-08 2:52 ` [PATCH] PM: Hide CONFIG_PM from users Frank Rowand
2011-02-08 14:15 ` Mark Brown
2011-02-08 14:29 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110208122159.GA8284@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).