Re: [PATCH 3/5] Kconfig files and Makefile for KBUS

[Randy Dunlap <rdunlap@xenotime.net>]

On Sun, 27 Feb 2011 18:11:46 +0000 Tony Ibbs wrote:

> From: Tibs <tibs@tonyibbs.co.uk>
> 
> Amend the ipc Makefile.
> Add an ipc Kconfig for KBUS.
> Amend the init Kconfig appropriately.
> 
> Signed-off-by: Tony Ibbs <tibs@tonyibbs.co.uk>
> ---
>  init/Kconfig |    3 ++
>  ipc/Kconfig  |   99 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  ipc/Makefile |    5 +++
>  3 files changed, 107 insertions(+), 0 deletions(-)
>  create mode 100644 ipc/Kconfig
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index c972899..a31a6fe 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -339,6 +339,8 @@ config AUDIT_TREE
>  	depends on AUDITSYSCALL
>  	select FSNOTIFY
>  
> +source "ipc/Kconfig"
> +
>  source "kernel/irq/Kconfig"
>  
>  menu "RCU Subsystem"
> @@ -1305,3 +1307,4 @@ config PADATA
>  	bool
>  
>  source "kernel/Kconfig.locks"
> +

You can drop that line.

> diff --git a/ipc/Kconfig b/ipc/Kconfig
> new file mode 100644
> index 0000000..46ebcda
> --- /dev/null
> +++ b/ipc/Kconfig
> @@ -0,0 +1,99 @@
> +config KBUS
> +        tristate "KBUS messaging system"
> +        default m

Use tabs to indent kconfig entry text, like above (not spaces).

Please do not enable new configs unless they are absolutely required.

> +        ---help---
> +	KBUS is a lightweight messaging system, particularly aimed
> +	at embedded platforms. This option provides the kernel support
> +	for mediating messages between client processes.
> +
> +	If you want KBUS support, you should say Y here.
> +
> +	This support can also be built as a module. If so, the module
> +	will be called kbus.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***