From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodore Ts'o Subject: Re: [PATCH] ext4: Reduce object size when !CONFIG_PRINTK Date: Tue, 18 Jun 2013 11:14:38 -0400 Message-ID: <20130618151438.GC7359@thunk.org> References: Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joe Perches Cc: linux-kernel@vger.kernel.org, Dave Kleikamp , linux-fsdevel , linux-embedded@vger.kernel.org, Andreas Dilger , linux-ext4@vger.kernel.org On Tue, Jun 04, 2013 at 07:55:05PM -0700, Joe Perches wrote: > Reduce the object size ~10% could be useful for embedded > systems. > > Add #ifdef CONFIG_PRINTK #else #endif blocks > to hold formats and arguments, passing " " to > functions when !CONFIG_PRINTK and still verifying > format and arguments with no_printk. > > $ size fs/ext4/built-in.o* > text data bss dec hex filename > 239375 610 888 240873 3ace9 fs/ext4/built-in.o.new > 264167 738 888 265793 40e41 fs/ext4/built-in.o.old > > $ grep -E "CONFIG_EXT4|CONFIG_PRINTK" .config > # CONFIG_PRINTK is not set > CONFIG_EXT4_FS=y > CONFIG_EXT4_USE_FOR_EXT23=y > CONFIG_EXT4_FS_POSIX_ACL=y > # CONFIG_EXT4_FS_SECURITY is not set > # CONFIG_EXT4_DEBUG is not set > > Signed-off-by: Joe Perches Applied, thanks. - Ted