From: Tejun Heo <tj@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: pmladek@suse.cz, Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Kay Sievers <kay@vrfy.org>, Josh Triplett <josh@joshtriplett.org>,
Linux Embedded <linux-embedded@vger.kernel.org>
Subject: Re: [PATCH 3/3] printk: implement support for extended console drivers
Date: Mon, 29 Jun 2015 11:28:05 -0400 [thread overview]
Message-ID: <20150629152805.GM15805@mtj.duckdns.org> (raw)
In-Reply-To: <CAMuHMdWwH-3kx1ma5KE=fP94by8boxM_QYqPKpU=YJw8t3hYeg@mail.gmail.com>
Hello,
On Mon, Jun 29, 2015 at 11:20:41AM +0200, Geert Uytterhoeven wrote:
> On Wed, Apr 29, 2015 at 4:45 PM, Tejun Heo <tj@kernel.org> wrote:
> > --- a/kernel/printk/printk.c
> > +++ b/kernel/printk/printk.c
>
> > @@ -2196,6 +2227,7 @@ out:
> > */
> > void console_unlock(void)
> > {
> > + static char ext_text[CONSOLE_EXT_LOG_MAX];
>
> Can you please
> a) make this feature optional,
netconsole itself is optional & modular. I'm not sure making further
splits is called for, especially given the use cases.
> b) (de)allocate this buffer dynamically when the first/last console with
> CON_EXTENDED set is (un)registered?
But yeah, making the buffer allocated on demand should be simple
enough. Will get to it.
Thanks.
--
tejun
next prev parent reply other threads:[~2015-06-29 15:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1430318704-32374-1-git-send-email-tj@kernel.org>
[not found] ` <1430318704-32374-4-git-send-email-tj@kernel.org>
2015-06-29 9:20 ` [PATCH 3/3] printk: implement support for extended console drivers Geert Uytterhoeven
2015-06-29 15:28 ` Tejun Heo [this message]
2015-06-29 15:47 ` Geert Uytterhoeven
2015-06-29 15:49 ` Tejun Heo
2015-06-29 16:11 ` josh
2015-06-29 16:11 ` Geert Uytterhoeven
2015-06-29 16:13 ` Tejun Heo
2015-06-29 16:50 ` josh
2015-06-29 23:31 ` [PATCH v4.2-rc1] printk: make extended printk support conditional on netconsole Tejun Heo
2015-07-01 16:05 ` Petr Mladek
2015-07-02 16:21 ` [PATCH v2 " Tejun Heo
2015-07-03 14:07 ` Petr Mladek
2015-07-03 15:25 ` Tejun Heo
2015-07-03 16:22 ` [PATCH v3 " Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150629152805.GM15805@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=josh@joshtriplett.org \
--cc=kay@vrfy.org \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pmladek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).