From: Tejun Heo <tj@kernel.org>
To: Petr Mladek <pmladek@suse.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Kay Sievers <kay@vrfy.org>, Josh Triplett <josh@joshtriplett.org>,
Linux Embedded <linux-embedded@vger.kernel.org>,
geert@linux-m68k.org
Subject: Re: [PATCH v2 v4.2-rc1] printk: make extended printk support conditional on netconsole
Date: Fri, 3 Jul 2015 11:25:55 -0400 [thread overview]
Message-ID: <20150703152555.GA5273@mtj.duckdns.org> (raw)
In-Reply-To: <20150703140352.GD32664@pathway.suse.cz>
On Fri, Jul 03, 2015 at 04:07:34PM +0200, Petr Mladek wrote:
> > @@ -2561,9 +2591,11 @@ void register_console(struct console *newcon)
> > console_drivers->next = newcon;
> > }
> >
> > - if (newcon->flags & CON_EXTENDED)
> > - if (!nr_ext_console_drivers++)
> > + if (newcon->flags & CON_EXTENDED) {
> > + if (!nr_ext_console_drivers)
> > pr_info("printk: continuation disabled due to ext consoles, expect more fragments in /dev/kmsg\n");
>
> I would move the check and the message into
> inc_nr_ext_console_drivers() when CONFIG_PRINTK_CON_EXTENDED is
> defined. It does not make sense if we do not increment the counter.
It doesn't make any difference as it gets compiled out anyway but yeah
moving it into the inc function makes more sense. Updating the patch.
Thanks.
--
tejun
next prev parent reply other threads:[~2015-07-03 15:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1430318704-32374-1-git-send-email-tj@kernel.org>
[not found] ` <1430318704-32374-4-git-send-email-tj@kernel.org>
2015-06-29 9:20 ` [PATCH 3/3] printk: implement support for extended console drivers Geert Uytterhoeven
2015-06-29 15:28 ` Tejun Heo
2015-06-29 15:47 ` Geert Uytterhoeven
2015-06-29 15:49 ` Tejun Heo
2015-06-29 16:11 ` josh
2015-06-29 16:11 ` Geert Uytterhoeven
2015-06-29 16:13 ` Tejun Heo
2015-06-29 16:50 ` josh
2015-06-29 23:31 ` [PATCH v4.2-rc1] printk: make extended printk support conditional on netconsole Tejun Heo
2015-07-01 16:05 ` Petr Mladek
2015-07-02 16:21 ` [PATCH v2 " Tejun Heo
2015-07-03 14:07 ` Petr Mladek
2015-07-03 15:25 ` Tejun Heo [this message]
2015-07-03 16:22 ` [PATCH v3 " Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150703152555.GA5273@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=josh@joshtriplett.org \
--cc=kay@vrfy.org \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).