From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH v2 v4.2-rc1] printk: make extended printk support
 conditional on netconsole
Date: Fri, 3 Jul 2015 11:25:55 -0400
Message-ID: <20150703152555.GA5273@mtj.duckdns.org>
References: <1430318704-32374-4-git-send-email-tj@kernel.org>
 <CAMuHMdWwH-3kx1ma5KE=fP94by8boxM_QYqPKpU=YJw8t3hYeg@mail.gmail.com>
 <20150629152805.GM15805@mtj.duckdns.org>
 <CAMuHMdXTn0+z4PV9UVZZmpMdk_-JUc4x-GqZweOhQyYMTzSOGQ@mail.gmail.com>
 <20150629154914.GQ15805@mtj.duckdns.org>
 <CAMuHMdX-cA3RccXF2kBifMEyT8e14rURp9Li_WFm7ODBOti=QQ@mail.gmail.com>
 <20150629161355.GS15805@mtj.duckdns.org>
 <20150629233140.GA7711@mtj.duckdns.org>
 <20150702162141.GC30677@mtj.duckdns.org>
 <20150703140352.GD32664@pathway.suse.cz>
Mime-Version: 1.0
Return-path: <linux-kernel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=sender:date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        bh=xiQ+SAokoZ24wkTo9A3HDLB1+AM89z0g0DOFmoTtfU4=;
        b=tNwpqvt2XRW+Jk1zzv5f9wK58rXSNnPkFZ3E6CiD7RB0qYZZ7MbHiqDMFT12IVbLcg
         4NKuKipTaDnxINtZVZNRRj9verHngt+qKwQpOWpnA11rX6o2uLngVYjb04ORySuyVaUY
         /EpivFXUnH7+a0qFG9ehPwb1xjWaZY51ZaJY2auHGQxPFWxbPTVvEDXA1e3suuwFD4NT
         wvrD73Lz/M8lmv/Utf6FCRJEQo2ikLm3sdjMf+nKvPg96rzYQblLVK3sbyrzer/I5I9o
         p0X+XkJ7F9aSIUynZiYsSEXcr0qJCbm3Z1U7yNlKHks+6JX7yPHAI/Gu9vUNvoNoTGjh
         JZZw==
Content-Disposition: inline
In-Reply-To: <20150703140352.GD32664@pathway.suse.cz>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-embedded.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Petr Mladek <pmladek@suse.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>, Andrew Morton <akpm@linux-foundation.org>, "David S. Miller" <davem@davemloft.net>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, Kay Sievers <kay@vrfy.org>, Josh Triplett <josh@joshtriplett.org>, Linux Embedded <linux-embedded@vger.kernel.org>, geert@linux-m68k.org

On Fri, Jul 03, 2015 at 04:07:34PM +0200, Petr Mladek wrote:
> > @@ -2561,9 +2591,11 @@ void register_console(struct console *newcon)
> >  		console_drivers->next = newcon;
> >  	}
> >  
> > -	if (newcon->flags & CON_EXTENDED)
> > -		if (!nr_ext_console_drivers++)
> > +	if (newcon->flags & CON_EXTENDED) {
> > +		if (!nr_ext_console_drivers)
> >  			pr_info("printk: continuation disabled due to ext consoles, expect more fragments in /dev/kmsg\n");
> 
> I would move the check and the message into
> inc_nr_ext_console_drivers() when CONFIG_PRINTK_CON_EXTENDED is
> defined. It does not make sense if we do not increment the counter.

It doesn't make any difference as it gets compiled out anyway but yeah
moving it into the inc function makes more sense.  Updating the patch.

Thanks.

-- 
tejun