From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [PATCH 2/3] tracing: Use pr_crit() instead of long fancy messages Date: Wed, 31 Mar 2021 09:40:07 -0400 Message-ID: <20210331094007.77aa5194@gandalf.local.home> References: <20210331093104.383705-1-geert+renesas@glider.be> <20210331093104.383705-3-geert+renesas@glider.be> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20210331093104.383705-3-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Sender: "iommu" To: Geert Uytterhoeven Cc: Petr Mladek , Marco Elver , linux-embedded-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, John Ogness , Linus Torvalds , Randy Dunlap , Rasmus Villemoes , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sergey Senozhatsky , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Ingo Molnar , Vlastimil Babka , Andrew Morton , Andy Shevchenko , Will Deacon , Gary R Hook On Wed, 31 Mar 2021 11:31:03 +0200 Geert Uytterhoeven wrote: > This reduces kernel size by ca. 0.5 KiB. If you are worried about size, disable tracing and it will go away entirely. 0.5KiB is a drop in the bucket compared to what tracing adds in size overhead. Sorry, but NAK. This has been very successful in stopping people from adding trace_printk() to the kernel, and I like to keep it that way. -- Steve