From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.54 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794496941; b=j3G5CYJsieGpXuYGHnra7CzPy8LnMml6So2qT3KQWZ5S1O1CywR4kCsKYscTS5BNSx2k q2hsJVj9PpQSBnCOCNzpthI1St+gBLCS/0mrktmjQq3wkpLVynXDwg1gHp5LrEUzaM9L+ wSp6Mk+2EYF4Cv5GqQLhi+P52sRk1QI22BrbHgO1aBupH6j/JieYCR/9Ymt5guPJmcwbY +e4dvGC7atlPkM8sgCpuiHG8Q3DCHPw1JxuzkecenzvWDM3yAEsK3nGrZeHp57De5pmKX FZ8gZ5384+J+PuoA1t/ewh6vT5M3ArMcEfHUKLROnaa1+l2LwgxJtNXCmREuSWlh0Cg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794496941; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-Id:X-Mailer:In-Reply-To:References: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=E8QRxqca6MPKKmYjqBq9RkAfrZBWcYxQ/ymz9RyAO8Y=; b=CPfOVaVoiJu/9dMgwmd3UulodBzLXMGlWpyakMWfVaGIeeCJBKhmF2fKrCn3qu5iv3j4 hsNl8PuX49C1ib0RA7YxcrKsazqLFOdQJlhltjv48Bt/qkFNfKE7BhOwhD874jWC+WLCz nPec17eRzq8itAYk3MewU7bCy/Hhzr5HLboHk5fR/GeBAvt/iBdse+Oama0+JKHRGScPG yTp+hImPkNRhunNnDk7m94Hm+/1MAy/xQIKZcy6+6u3mKsR4HJlXVCuTp/vmwSKwpHm0R z+68umGkdjF0G1bgkstbSrLH29/64TdKI3UjlQfSRY21pi6FqTADDKy+6ejLdd23DSg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=CFNCS1RQ; arc=none smtp.remote-ip=209.85.221.54 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7137460A3837 for ; Thu, 12 Nov 2026 15:22:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 7137460A3837 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=CFNCS1RQ Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-497614c95f0so2510431f8f.1 for ; Thu, 12 Nov 2026 07:22:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794496940; x=1795101740; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=E8QRxqca6MPKKmYjqBq9RkAfrZBWcYxQ/ymz9RyAO8Y=; b=CFNCS1RQhtbSxMwdv4RT7HaDOzw5D755nrRVwkL4k/OwRxOF9nDaPmGgbE6aBTSXWH msk1dQ3pVIxMk4yUT4CG9M7TNrpwaoIvNpJ3/pm/e0iSCd4XEBJKI8p9xJEwtSIfutCC stsi/5l34qljqB3RcnE4mIfJDNGptsv048CrwnBwOr0aEQYAk0b59wCbdRvQ6o8OL+fb cvAtr7bg4Ikai7/soQQ6V0PODVJ4pPFSeLLwUnbQMGtni8xKfY3UKMvp3w+fEstsPVjc i5FAdugW53dj2trdg9Fn6RkfhC18gt5RpmdSGsBIKL2h48wr0gH7pQH+a3qJOwITfh9h SU1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794496940; x=1795101740; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=E8QRxqca6MPKKmYjqBq9RkAfrZBWcYxQ/ymz9RyAO8Y=; b=13oWVdoV6V6UFezBQcyjsDrYJLT9d1SErjaC6uT92kN5FVIiSODDtSITMK2rDpVVRF JKU2qv1KmyS6HR4HIFrlvXlxkzAnHSeV34sApnHqMEq/Xzy1K8dJ2BX+xGYL2rBbJ/HB MYnyKsVaBP1/gSsHs7a0q8D4Am/39SfemXzyZXPvSk4loK+ZgZAC1MO0/0StnJH2HuuU 4OMKeiAiSwOwGkxogpVWTFjy+RztKnWHY2F9FgBWmxdO8/9O6B0meii3MGuhJ1hHKRQc QS6GN/B3Olrvf+JcPBWtiW0h5qvCmBaZy6XksGWmTp70dfUDZJN987H/+xsiXvZgYZat SOlQ== X-Forwarded-Encrypted: i=1; AL+hErEoIp32uIlZkysXy9CBpyecg5oXpfUylgIHGE43c4HMuW1ZaV+OLsA+BMKg8ywk2eUiGYFR9+B9RQhZUCNgFg==@vger.kernel.org X-Gm-Message-State: APuU4Z8j6brAAhTd7ZAPfyp9cGgY8lmh3IV7gJJ6/X7P5/DDBQ/5O5Ri cmik+GSnVQ4ueBKgUYsuTn3vNw6dK0AUxDtlk9gAPFL18Y3OgCc1luHa X-Gm-Gg: AYBFou0F2kt1IGKbfnf8T+zgslF0uo8kGryearlYruXkAM+5XTVsgtnzGbqDDaHqBKK rThQiu8wWtz0ds/plR8D9+VzjSDucfdA+5HDm27nqqzGnbXr6X2+bhCV4/sblR2KJTo4LilYkmx rDOFTT5L5rjoUdSLGTBhgFCFhN0ZGPOevor/NQJKSF5lS79gepBTeigDuQSH0C/yWUco99JufWO bj9L0TN7MrQihV/f8dZejCrsiFDJi75CO15jkxmg46R9eFk2dAZs43iSyTHNlNZMDEQ7yVwJ8oH ZHO3BrSvoaLunoZnmLO6VuzsI+4ipCwQETuMq9wunGN7CGClaVhdGirrg0eHcPsmjO2LdH4VoBN iYeXyVPDFyHROMI22Bvx5BhX0tBudvsKxlbTIpH5Z35d2s/QqneI8aGlo41b+0CsNoao3xYpCHC 5ZFpiADGAkl4QyPZkue1vusf0nQpVROT8wuuRYSPqPwLOfCKAYGoQgcCh2uteaIpqyICV8JcgMf 6Bu4l5ngoObfMmpn043J6MQnsH9m7rbZ/c2kOFc4hyYIIRVqnuaFOS1sdPyhfbsSCjynr+deJFd BLGfbP/IhrCuUR4nrV1rv8f7gwkCaFJSZ0PtrpweMGuICdxE4I1Bz/o= X-Received: by 2002:a05:600c:1c0d:b0:4a2:1e1:d55 with SMTP id 5b1f17b1804b1-4ba093a3cf9mr132094285e9.28.1794496939343; Thu, 12 Nov 2026 07:22:19 -0800 (PST) Received: from ingenieria31.oficinasStQ.local ([79.117.0.220]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4bb4e252f7fsm84746205e9.2.2026.11.12.07.22.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2026 07:22:18 -0800 (PST) From: =?UTF-8?q?M=C3=A0xim=20Pedraza=20Padilla?= To: Thomas Zimmermann Cc: Javier Martinez Canillas , Francesco Valla , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ard Biesheuvel , Jonathan Corbet , Helge Deller , Peter Jones , Jani Nikula , Mario Limonciello , Jocelyn Falempe , Sam Ravnborg , Ilias Apalodimas , Shuah Khan , Randy Dunlap , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-efi@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-embedded@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 00/15] Add splash DRM client Date: Thu, 12 Nov 2026 16:22:09 +0100 Message-Id: <20261112152209.3297409-1-maximpedraza@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <066197a1-aa2b-455b-84d8-4e2215fad764@suse.de> References: <20261027135342.2003632-1-maximpedraza@gmail.com> <066197a1-aa2b-455b-84d8-4e2215fad764@suse.de> X-Mailing-List: linux-embedded@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Thomas, Javier, Francesco, Thanks a lot for the reviews. I'm answering everything here in one go. On 11/11/26 14:52, Thomas Zimmermann wrote: > So shall we merge patches 1 to 6 and 8 first? You'd have something in > upstream already and not chase a moving target. From there, we can merge > the other features in the coming weeks. Yes, that sounds great. v7 is ready and holds just those: patches 1 to 4, 6 and 8 of v6, with the MAINTAINERS entry squashed into the patch that adds drm_splash.c, so six patches in all. The DT binding, the placement and rotation, and the connector orientation will follow as a separate series once this one is in. What changes in v7 from your comments: - the Assisted-by tags are gone from every patch (Javier) - MAINTAINERS: I'm listed as M: and Francesco as R: (thanks, Francesco), in the same patch as drm_splash.c - the firmware source is now DRM_SPLASH_SRC_FW, and the Kconfig options DRM_CLIENT_SPLASH_SRC_FW and DRM_CLIENT_SPLASH_FW_NAME; the BMP decoder keeps its name, since the BGRT goes through it too - the drm_splash_fw_load() stub returns 0 On the CONFIG_X86 around the BGRT check in patch 4: it comes from efifb, where efifb_bgrt_sanity_check() is x86 only too, and its comment says that all x86 firmwares centre the image horizontally. I haven't found that promised for other architectures, and there the check could reject a logo that is fine, so I'd rather keep it as efifb does. If you prefer it on every architecture, or gone, I'll change it. The issue Sashiko found on v6 (a restore deferred while the device was suspended) is fixed in v7, together with a few more that a later Sashiko run found; the changelog of patch 4 lists them. About your Reviewed-by on patch 4: since v6 the work has changed quite a bit. Restore now leaves the commit to the work, a hotplug while userspace holds the display waits for the next restore as fbdev does, and unregister waits for the work before it looks for a pending firmware request. Shall I keep your tag, or drop it so you can look at the new version first? Whichever you prefer. I'll send v7 shortly. Best regards, Màxim