From: David VomLehn <dvomlehn@cisco.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Daniel Walker <dwalker@mvista.com>, linux-embedded@vger.kernel.org
Subject: Re: [PATCH] [RFC] emit-crash-char: Allow diversion of printk output for crash logging
Date: Tue, 12 Aug 2008 18:30:54 -0700 [thread overview]
Message-ID: <48A2394E.8030500@cisco.com> (raw)
In-Reply-To: <fa686aa40808121539pc02a645n908500844c698bca@mail.gmail.com>
Grant Likely wrote:
> I'm not thrilled with this patch. It seems so much more straight
> forward in your special case, but it comes at the expense of making
> the code path more complex in every other case.
>
> I would much rather see this be done using the existing console driver
> interface. The only possible reason I could see wanting to do things
> this way is if you don't trust the console code to call your console
> driver, which I think is a pretty unlikely case.
I'll buy that reasoning.
Regardless of implementation, it seems to me that it could be of use for some
other embedded platforms. Any suggestions as to where it should go in the tree?
drivers/char? drivers/misc?
> --
> Grant Likely, B.Sc., P.Eng.
> Secret Lab Technologies Ltd.
--
David VomLehn
next prev parent reply other threads:[~2008-08-13 1:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 2:20 [PATCH] [RFC] emit-crash-char: Allow diversion of printk output for crash logging David VomLehn
2008-08-08 15:55 ` Daniel Walker
2008-08-08 16:05 ` Mike Frysinger
2008-08-08 16:17 ` Daniel Walker
2008-08-08 18:09 ` Mike Frysinger
2008-08-08 20:10 ` Daniel Walker
2008-08-08 20:13 ` Mike Frysinger
2008-08-08 20:47 ` Daniel Walker
2008-08-08 21:24 ` [PATCH] [RFC] emit-crash-char: Allow diversion of printkoutput " Haller, John H (John)
2008-08-08 22:01 ` Daniel Walker
2008-08-11 23:34 ` [PATCH] [RFC] emit-crash-char: Allow diversion of printk output " David VomLehn
2008-08-12 22:39 ` Grant Likely
2008-08-13 1:30 ` David VomLehn [this message]
2008-08-13 2:12 ` Grant Likely
2008-08-13 17:56 ` David VomLehn
2008-08-13 19:02 ` Tim Bird
2008-08-13 20:27 ` David VomLehn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A2394E.8030500@cisco.com \
--to=dvomlehn@cisco.com \
--cc=dwalker@mvista.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-embedded@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).