From: "H. Peter Anvin" <hpa@zytor.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
linux-kernel@vger.kernel.org, linux-embedded@vger.kernel.org,
tglx@linutronix.de, mingo@redhat.com, michael@free-electrons.com
Subject: Re: [PATCH 1/1] [x86] Configuration options to compile out x86 CPU support code
Date: Fri, 15 Aug 2008 13:36:12 -0700 [thread overview]
Message-ID: <48A5E8BC.6060601@zytor.com> (raw)
In-Reply-To: <20080815141855.GB12954@elte.hu>
Ingo Molnar wrote:
> * Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
>
>> This patch adds some configuration options that allow to compile out
>> CPU vendor-specific code in x86 kernels (in arch/x86/kernel/cpu). The
>> new configuration options are only visible when CONFIG_EMBEDDED is
>> selected, as they are mostly interesting for space savings reasons.
>>
>> An example of size saving, on x86 with only Intel CPU support:
>>
>> text data bss dec hex filename
>> 1125479 118760 212992 1457231 163c4f vmlinux.old
>> 1121355 116536 212992 1450883 162383 vmlinux
>> -4124 -2224 0 -6348 -18CC +/-
>>
>> However, I'm not exactly sure that the Kconfig wording is correct with
>> regard to !64BIT / 64BIT.
>
> applied to tip/x86/cpu, thanks Thomas. (I've done a trivial cleanup:
> converted the macro to an inline.)
>
> Peter, do you like this version of the patch or would you like further
> improvements?
>
I'm fine with it.
I think there might still be cross-dependencies, but it doesn't break
anything old, so we can deal with that via bug reports.
The other thing that probably should be done is breaking out the
Intel-specific versus generic parts of intel_cacheinfo.c.
-hpa
next prev parent reply other threads:[~2008-08-15 20:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 9:45 [PATCH 1/1] [x86] Configuration options to compile out x86 CPU support code Thomas Petazzoni
2008-08-15 14:18 ` Ingo Molnar
2008-08-15 14:38 ` Ingo Molnar
2008-08-18 10:33 ` [PATCH] [x86] Make movsl_mask definition non-CPU specific Thomas Petazzoni
2008-08-18 10:33 ` [PATCH] [x86] Move cmpxchg fallbacks to a generic place Thomas Petazzoni
2008-08-18 14:07 ` Ingo Molnar
2008-08-15 20:36 ` H. Peter Anvin [this message]
[not found] <20030410181011$6d15@gated-at.bofh.it>
[not found] ` <aXrl4-2FX-1@gated-at.bofh.it>
2008-08-09 14:08 ` [PATCH 1/1] [x86] Configuration options to compile out x86 CPU support code Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A5E8BC.6060601@zytor.com \
--to=hpa@zytor.com \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@free-electrons.com \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).