linux-embedded.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phillip Lougher <phillip@lougher.demon.co.uk>
To: "Jörn Engel" <joern@logfs.org>
Cc: akpm@linux-foundation.org, linux-embedded@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	tim.bird@am.sony.com
Subject: Re: Subject: [PATCH 01/16] Squashfs: inode operations
Date: Tue, 21 Oct 2008 01:32:43 +0100	[thread overview]
Message-ID: <48FD232B.10508@lougher.demon.co.uk> (raw)
In-Reply-To: <20081017165300.GA8076@logfs.org>

Jörn Engel wrote:
> None of the comments below are a reason against mainline inclusion, imo.
> They should get handled, but whether that happens before or after a
> merge doesn't really matter.

Yeah you're right regarding your comments.  That's where code-review 
comes in handy, to spot things you don't see because you're too used to 
the code.

I'm working on a re-spin incorporating your comments, and it should be 
ready tomorrow.

Thanks for the code-review.

Phillip

  reply	other threads:[~2008-10-21  0:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-17 15:42 Subject: [PATCH 01/16] Squashfs: inode operations Phillip Lougher
2008-10-17 16:53 ` Jörn Engel
2008-10-21  0:32   ` Phillip Lougher [this message]
2008-10-21 16:14   ` David P. Quigley
2008-10-21 18:03     ` Jörn Engel
2008-10-22  8:48     ` Christoph Hellwig
2008-10-22 16:32 ` Geert Uytterhoeven
2008-10-22 17:13 ` Geert Uytterhoeven
2008-10-23  8:42   ` Phillip Lougher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48FD232B.10508@lougher.demon.co.uk \
    --to=phillip@lougher.demon.co.uk \
    --cc=akpm@linux-foundation.org \
    --cc=joern@logfs.org \
    --cc=linux-embedded@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tim.bird@am.sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).