From: Phillip Lougher <phillip@lougher.demon.co.uk>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: akpm@linux-foundation.org, linux-embedded@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
tim.bird@am.sony.com
Subject: Re: Subject: [PATCH 01/16] Squashfs: inode operations
Date: Thu, 23 Oct 2008 09:42:17 +0100 [thread overview]
Message-ID: <490038E9.7050902@lougher.demon.co.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.0810221907080.20919@vixen.sonytel.be>
Geert Uytterhoeven wrote:
> Sparse with endian checking (make C=2 CHECKFLAGS="-D__CHECK_ENDIAN__") complains
> aibout these:
>
> | fs/squashfs/inode.c:306:25: warning: cast to restricted __le16
> | fs/squashfs/inode.c:324:25: warning: cast to restricted __le16
>
> and it seems to be right, as inode.i_mode is not __le16. I think the le16_to_cpu()
> should be removed.
Yes, you're right. Fixed thanks.
>
> BTW, there are also a few sparse warnings about different signednesses, so you
> probably want to run sparse yourself, too.
I'll do that.
Phillip
prev parent reply other threads:[~2008-10-23 8:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 15:42 Subject: [PATCH 01/16] Squashfs: inode operations Phillip Lougher
2008-10-17 16:53 ` Jörn Engel
2008-10-21 0:32 ` Phillip Lougher
2008-10-21 16:14 ` David P. Quigley
2008-10-21 18:03 ` Jörn Engel
2008-10-22 8:48 ` Christoph Hellwig
2008-10-22 16:32 ` Geert Uytterhoeven
2008-10-22 17:13 ` Geert Uytterhoeven
2008-10-23 8:42 ` Phillip Lougher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490038E9.7050902@lougher.demon.co.uk \
--to=phillip@lougher.demon.co.uk \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=akpm@linux-foundation.org \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).