From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marco Subject: Re: [PATCH 04/14] Pramfs: Mounting as root filesystem Date: Sun, 14 Jun 2009 18:29:38 +0200 Message-ID: <4A352572.50602@alice.it> References: <4A33A7D7.3040008@gmail.com> <200906140104.43463.arnd@arndb.de> <4A34B2FD.20701@gmail.com> <1244970445.3468.2732.camel@macbook.infradead.org> <4A351FB0.3060008@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4A351FB0.3060008@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Marco Cc: David Woodhouse , Arnd Bergmann , Linux FS Devel , Linux Embedded , Linux Kernel , Daniel Walker David Woodhouse wrote: > On Sun, 2009-06-14 at 10:21 +0200, Marco wrote: >> Mmm...MEM_MAJOR and RAMDISK_MAJOR have the same value and pramfs works >> in memory. We could simply use /dev/null (there was an error in the >> submitted kconfig description, my intention was to use /dev/mem). In >> that case I can use UNNAMED_MAJOR. PRAMFS root option is not enabled >> if it's already enabled the NFS one. What do you think? > > Why use a major number at all? See how we handle mtd and ubi devices in > prepare_namespace() -- can't you do something similar? > Do you suggest me something similar? Why not. I though that mtd and ubi were only special cases. if (saved_root_name[0]) { root_device_name = saved_root_name; if (!strncmp(root_device_name, "mtd", 3) || !strncmp(root_device_name, "ubi", 3) || --------> !strncmp(root_device_name, "pram", 4)) { mount_block_root(root_device_name, root_mountflags); goto out; } ROOT_DEV = name_to_dev_t(root_device_name); if (strncmp(root_device_name, "/dev/", 5) == 0) root_device_name += 5; }