From: Marco Stornelli <marco.stornelli@gmail.com>
To: Marc Andre Tanner <mat@brain-dump.org>
Cc: linux-embedded@vger.kernel.org
Subject: Re: [PATCH 5/5] printk: provide a filtering macro for printk
Date: Wed, 02 Sep 2009 18:44:19 +0200 [thread overview]
Message-ID: <4A9EA0E3.8000603@gmail.com> (raw)
In-Reply-To: <1251901505-4313-6-git-send-email-mat@brain-dump.org>
Marc Andre Tanner ha scritto:
> +#define printk(fmt, ...) ( \
Shouldn't it be an and?
> + (!__builtin_constant_p(PRINTK_FILTER((fmt))) || PRINTK_FILTER((fmt))) ? \
> + printk((fmt), ##__VA_ARGS__) : 0 \
> +)
> +
> +#endif /* CONFIG_PRINTK_VERBOSITY */
> +
Marco
next prev parent reply other threads:[~2009-09-02 16:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 14:25 [RFC|PATCHv2] Compile time printk verbosity Marc Andre Tanner
2009-09-02 14:25 ` [PATCH 1/5] printk: introduce CONFIG_PRINTK_VERBOSITY Marc Andre Tanner
2009-09-02 16:44 ` Marco Stornelli
2009-09-02 17:32 ` Marc Andre Tanner
2009-09-02 14:25 ` [PATCH 2/5] printk: move printk to the end of the file Marc Andre Tanner
2009-09-02 14:25 ` [PATCH 3/5] printk: introduce printk_unfiltered as an alias to printk Marc Andre Tanner
2009-09-02 14:25 ` [PATCH 4/5] char/mem: replace printk with printk_unfiltered Marc Andre Tanner
2009-09-02 14:25 ` [PATCH 5/5] printk: provide a filtering macro for printk Marc Andre Tanner
2009-09-02 16:44 ` Marco Stornelli [this message]
2009-09-02 17:27 ` Marc Andre Tanner
2009-09-03 6:29 ` Marco Stornelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9EA0E3.8000603@gmail.com \
--to=marco.stornelli@gmail.com \
--cc=linux-embedded@vger.kernel.org \
--cc=mat@brain-dump.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).