From: Phillip Lougher <phillip-cnXvMjJKhjYG2Il/BtU0GPXRex20P6io@public.gmane.org>
To: Tim Bird <tim.bird-mEdOJwZ7QcZBDgjK7y7TUQ@public.gmane.org>
Cc: squashfs-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-embedded
<linux-embedded-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Matt Mackall <mpm-VDJrAJ4Gl5ZBDgjK7y7TUQ@public.gmane.org>
Subject: Re: Status of SquashFS LZMA support in mainline
Date: Thu, 22 Apr 2010 02:37:25 +0100 [thread overview]
Message-ID: <4BCFA855.8070407@lougher.demon.co.uk> (raw)
In-Reply-To: <4BCF9863.2000903-mEdOJwZ7QcZBDgjK7y7TUQ@public.gmane.org>
Tim Bird wrote:
> Does anyone (Phillip?) know the status of SquashFS support
> for LZMA compression in mainline? I seem to recall that
> Phillip got the patches for this into linux-next sometime
> in January, but I'm not sure if the latest kernel
> (2.6.34-rcxx) includes this or not.
>
Short answer, no it doesn't include this, Linus rejected my
changes to the LZMA code that made it available for
use by non init code (the LZMA code is currently only used by
initramfs/initrd and the kernel decompression code).
See the thread with the response from Linus here
http://linux.derkeiler.com/Mailing-Lists/Kernel/2010-03/msg01462.html
So even though AFAIK there was no issues with the Squashfs LZMA
wrapper, I had to drop it because it's useless without my changes
to the LZMA code.
I salvaged as much as possible, and submitted a second pull request
with only the new Squashfs decompression framework (so it can use different
decompressors cleanly). This was accepted.
> I also see in Linus' git tree the following commits in
> March:
>
> 2010-03-05 Linus Torvalds Merge git://git.kernel.org/pub/scm/linux/kernel/git...
> ...git://git./linux/kernel/git/pkl/squashfs-linus
> ...org/pub/scm/linux/kernel/git/pkl/squashfs-linus:
> Squashfs: get rid of obsolete definition...
> Squashfs: get rid of obsolete variable...
> Squashfs: add decompressor entries for...
> Squashfs: add a decompressor framework
> Squashfs: factor out remaining zlib dependencies...
> Squashfs: move zlib decompression wrapper...
The partial pull is why the commit history is slightly confusing, part of the
work is there, but all LZMA work is mysteriously missing.
What now? It's clear the Squashfs LZMA work isn't going to be accepted until
I clean up the STATIC and __init mess that Linus objected to. This is one
of my next tasks when I get enough free time to work through the issues. It
may be quite a lot of work because to fix this requires touching quite a
few different architecture files. It's not something that's going to be fixed
in a couple of evenings :-(
Phillip
------------------------------------------------------------------------------
prev parent reply other threads:[~2010-04-22 1:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 0:29 Status of SquashFS LZMA support in mainline Tim Bird
[not found] ` <4BCF9863.2000903-mEdOJwZ7QcZBDgjK7y7TUQ@public.gmane.org>
2010-04-22 1:37 ` Phillip Lougher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCFA855.8070407@lougher.demon.co.uk \
--to=phillip-cnxvmjjkhjyg2il/btu0gpxrex20p6io@public.gmane.org \
--cc=linux-embedded-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mpm-VDJrAJ4Gl5ZBDgjK7y7TUQ@public.gmane.org \
--cc=squashfs-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=tim.bird-mEdOJwZ7QcZBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).