From: Marco Stornelli <marco.stornelli@gmail.com>
To: James Hogan <james@albanarts.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Linux Embedded <linux-embedded@vger.kernel.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Tim Bird <tim.bird@am.sony.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 02/16 v2] pramfs: super block operations
Date: Sat, 06 Nov 2010 15:59:51 +0100 [thread overview]
Message-ID: <4CD56D67.9090106@gmail.com> (raw)
In-Reply-To: <20101106111627.GA13497@gandalf.local>
Il 06/11/2010 12:16, James Hogan ha scritto:
> Hi Marco,
>
> On Sat, Nov 06, 2010 at 09:56:39AM +0100, Marco Stornelli wrote:
>> From: Marco Stornelli <marco.stornelli@gmail.com>
>> +static void pram_set_blocksize(struct super_block *sb, unsigned long size)
>> +{
>> + int bits;
>> +
>> + /*
>> + * We've already validated the user input and the value here must be
>> + * between PRAM_MAX_BLOCK_SIZE and PRAM_MIN_BLOCK_SIZE
>> + * and it must be a power of 2.
>> + */
>
> Should this comment have spaces after the tabs to be consistent with the
> other multiline comments (pram_ioremap) and the coding style?
>
Ok, no problem.
Thanks for the review.
Regards,
Marco
next prev parent reply other threads:[~2010-11-06 14:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-06 8:56 [PATCH 02/16 v2] pramfs: super block operations Marco Stornelli
2010-11-06 11:16 ` James Hogan
2010-11-06 14:59 ` Marco Stornelli [this message]
2010-11-06 13:12 ` James Hogan
2010-11-06 14:59 ` Marco Stornelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD56D67.9090106@gmail.com \
--to=marco.stornelli@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=james@albanarts.com \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).