From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Bird Subject: Re: [PATCH v5] selftest: size: Add size test for Linux kernel Date: Wed, 3 Dec 2014 08:13:14 -0800 Message-ID: <547F369A.3000106@sonymobile.com> References: <547E854E.5060101@sonymobile.com> <1417578191.16722.11.camel@concordia> <20141203140136.12997331@free-electrons.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141203140136.12997331@free-electrons.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Thomas Petazzoni , Michael Ellerman Cc: Shuah Khan , "linux-api@vger.kernel.org" , Josh Triplett , "linux-kernel@vger.kernel.org" , "linux-embedded@vger.kernel.org" On 12/03/2014 05:01 AM, Thomas Petazzoni wrote: > Michael, Tim, > > On Wed, 03 Dec 2014 14:43:11 +1100, Michael Ellerman wrote: > >>> diff --git a/tools/testing/selftests/size/Makefile b/tools/testing/selftests/size/Makefile >>> new file mode 100644 >>> index 0000000..47f8e9c >>> --- /dev/null >>> +++ b/tools/testing/selftests/size/Makefile >>> @@ -0,0 +1,15 @@ >>> +#ifndef CC >>> + CC = $(CROSS_COMPILE)gcc >>> +#endif >> >> I think the following is preferable: >> >> CC := $(CROSS_COMPILE)$(CC) > > It is even more necessary that #ifndef and #endif don't exist in make. > They are just comments, and therefore, ignored. Seems like Tim does too > much C :-) OK - that's hilarious. Saying 'Oops!' would be too casual for my degree of embarrassment. :-) Makefiles do have similar constructs. Those should have been ifeq ($(CC),) ... endif This obviously got through via a failiure in testing - which is somewhat ironic. Look for a v6 soon. (Geez, when is the merge window coming. I thought this trivial program would get in pretty easily, but no... that's never the way. Of course it helps if the submitter is not an idiot.) -- Tim