From: "Jared Hulbert" <jaredeh@gmail.com>
To: Sven Wegener <sven.wegener@stealer.net>
Cc: Linux-kernel@vger.kernel.org, linux-embedded@vger.kernel.org,
linux-mtd <linux-mtd@lists.infradead.org>,
"Jörn Engel" <joern@logfs.org>,
tim.bird@am.sony.com, cotte@de.ibm.com, nickpiggin@yahoo.com.au
Subject: Re: [PATCH 10/10] AXFS: axfs_uncompress.c
Date: Thu, 21 Aug 2008 07:37:27 -0700 [thread overview]
Message-ID: <6934efce0808210737w16b5f8dcr1657ea46099e4901@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.1.10.0808211028150.12259@titan.stealer.net>
> Use DEFINE_MUTEX and drop the mutex_init() down in the init function.
okay. by drop you mean delete?
> axfs_uncompress_init() and axfs_uncompress_exit() are only called during
> init and exit of the module, no need for the initialized variable and the
> functions can be annotated with __init and __exit.
can be annotated or should be?
next prev parent reply other threads:[~2008-08-21 14:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 5:46 [PATCH 10/10] AXFS: axfs_uncompress.c Jared Hulbert
2008-08-21 9:01 ` Sven Wegener
2008-08-21 14:37 ` Jared Hulbert [this message]
2008-08-21 14:53 ` Sven Wegener
2008-08-21 11:40 ` Artem Bityutskiy
2008-08-21 12:28 ` Geert Uytterhoeven
2008-08-21 14:35 ` Jared Hulbert
2008-08-29 13:48 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6934efce0808210737w16b5f8dcr1657ea46099e4901@mail.gmail.com \
--to=jaredeh@gmail.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=cotte@de.ibm.com \
--cc=joern@logfs.org \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nickpiggin@yahoo.com.au \
--cc=sven.wegener@stealer.net \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).