From: "Jared Hulbert" <jaredeh@gmail.com>
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Cc: Linux-kernel@vger.kernel.org, linux-embedded@vger.kernel.org,
linux-mtd <linux-mtd@lists.infradead.org>,
"Jörn Engel" <joern@logfs.org>,
tim.bird@am.sony.com, cotte@de.ibm.com, nickpiggin@yahoo.com.au
Subject: Re: [PATCH 07/10] AXFS: axfs_bdev.c
Date: Fri, 22 Aug 2008 10:39:18 -0700 [thread overview]
Message-ID: <6934efce0808221039o3ea57e35ka24a617621e2646e@mail.gmail.com> (raw)
In-Reply-To: <20080822125440.GA1396@mx.loc>
> mismatch between documentation and implementation WRT the function name ;)
oops.
>>+{
>>+ struct axfs_super *sbi = AXFS_SB(sb);
>>+ u64 boffset = AXFS_FSOFFSET_2_DEVOFFSET(sbi, fsoffset);
>>+ u64 blocks;
>>+ u64 blksize = sb->s_blocksize;
>>+ unsigned long dst;
>>+ unsigned long src;
>>+ sector_t block;
>>+ size_t bytes;
>>+ struct buffer_head *bh;
>>+ u64 copied = 0;
>>+
>>+ if (len == 0)
>>+ return 0;
>>+
>>+ blocks = len / blksize;
>>+ if ((len % blksize) > 0)
>>+ blocks += 1;
>>+
>>+ while (copied < len) {
>>+ /* Explicit casting for ARM linker errors. */
>
> did it try to emit some external div()? Is this still needed?
exactly. I haven't heard otherwise, it was a Freescale ARM11 build
that had the issue... I don't have the set up.
next prev parent reply other threads:[~2008-08-22 17:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 5:45 [PATCH 07/10] AXFS: axfs_bdev.c Jared Hulbert
2008-08-22 12:54 ` Bernhard Reutner-Fischer
2008-08-22 17:39 ` Jared Hulbert [this message]
2008-08-24 8:19 ` MinChan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6934efce0808221039o3ea57e35ka24a617621e2646e@mail.gmail.com \
--to=jaredeh@gmail.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=cotte@de.ibm.com \
--cc=joern@logfs.org \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nickpiggin@yahoo.com.au \
--cc=rep.dot.nop@gmail.com \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).