From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Mike Frysinger" Subject: Re: [PATCH 0/1] Embedded Maintainer(s), linux-embedded@vger list Date: Thu, 12 Jun 2008 17:46:42 -0400 Message-ID: <8bd0f97a0806121446i68af3b96sbe51cc510f7d4fb6@mail.gmail.com> References: <1209577322.25560.402.camel@pmac.infradead.org> <200806102235.09598.rob@landley.net> <484F66F8.4020409@snapgear.com> <200806111941.51221.rob@landley.net> <20080612182529.GB7423@nibiru.local> <485190E8.80705@cisco.com> <48519837.1090902@katalix.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=8DjFWiLDOGaWtH7e3Tdb9ulLRwmVvqOSCYAXFWkf+nE=; b=QDyLqUTVUv5qe5EXYfAtYM5L0nUy016AG1VB6CIukVM5mDfiquP73koUcVrKlgxYcG DI3LqAamfUDa0E/kmEQFt2o34yxv9kUERbiao3cXXJKkFhToCrY1HnrkwgehP5KEUC91 prVi7OTaTmMjTY6ZLcRA+Om+IEnOm71U/D/LY= In-Reply-To: <48519837.1090902@katalix.com> Content-Disposition: inline Sender: linux-embedded-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: James Chapman Cc: David VomLehn , weigelt@metux.de, Linux Embedded Maillist On Thu, Jun 12, 2008 at 5:42 PM, James Chapman wrote: > David VomLehn wrote: >> Amen, brother. I'm fortunate in that I work for an organization that is >> quite good about enforcing code reviews, specifically, the QA organization >> is empowered to reject changes that do not have code review notes. I also >> have a fairly broad scope, so I'm in on code reviews for a number of open >> source components. At each such review, one of my criteria is whether the >> change is suitable for pushing back to the appropriate community. This is >> not necessarily a short-term way to make friends, but the long-term effects >> will be good both for the company and for the open source community in >> general. >> >> Now, if we can only get the time to actually push all the backlogged fixes >> out... > > Er, is that GPL or LGPL code that you're modifying? If so, you *have* to > push those code changes out (make them available to others), whether you > think people will be interested or not! umm, not really. only if (1) he gives a binary to someone and (2) they ask him for the source. if he doesnt distribute or no one asks, he doesnt have to do squat. -mike