From: "Mike Frysinger" <vapier.adi@gmail.com>
To: Daniel Walker <dwalker@mvista.com>
Cc: dvomlehn@cisco.com, linux-embedded@vger.kernel.org
Subject: Re: [PATCH] [RFC] emit-crash-char: Allow diversion of printk output for crash logging
Date: Fri, 8 Aug 2008 16:13:44 -0400 [thread overview]
Message-ID: <8bd0f97a0808081313v4df788b9xcd25308ca64b0862@mail.gmail.com> (raw)
In-Reply-To: <1218226225.19162.189.camel@localhost.localdomain>
On Fri, Aug 8, 2008 at 4:10 PM, Daniel Walker wrote:
> On Fri, 2008-08-08 at 14:09 -0400, Mike Frysinger wrote:
>> > I invite you to give some of the "plenty of
>> > examples in the tree", you might surprise me..
>>
>> look at all the new syscalls added without any userspace code in place
>> (still) to use it. or Linus' recent printk modifier extension. or my
>> printk extensions for extracting portions of the kernel log buffer.
>> people usually submit interfaces with backend extesions, or the intent
>> to use it is obvious.
>
> Syscalls and Userspace are unrelated .. You clearly can't add userspace
> code to the kernel .. If you add a _kernel_ interface like David has
> done you need at least one user of the interface.. Otherwise it's just
> plain bloat inside the kernel which no one wants.
>
> Your changes for extracting part of the kernel log buffer (commit
> 0b15d04af3dd996035d8fa81fc849d049171f9c3),
>
> with:
> text data bss dec hex filename
> 4322000 386760 2592768 7301528 6f6998 vmlinux
> without:
> text data bss dec hex filename
> 4321876 386760 2592768 7301404 6f691c vmlinux
>
> Adds roughly 120bytes of bloat to my kernel, since 2007 .. What's the
> point? I grepped for users , and there are none ..
same sort of things as the point of David's code. early/crash
scenarios for people to safely extract portions of the kernel log
buffer for transmission/storage elsewhere. as was explained in the
original thread behind the commit.
-mike
next prev parent reply other threads:[~2008-08-08 20:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 2:20 [PATCH] [RFC] emit-crash-char: Allow diversion of printk output for crash logging David VomLehn
2008-08-08 15:55 ` Daniel Walker
2008-08-08 16:05 ` Mike Frysinger
2008-08-08 16:17 ` Daniel Walker
2008-08-08 18:09 ` Mike Frysinger
2008-08-08 20:10 ` Daniel Walker
2008-08-08 20:13 ` Mike Frysinger [this message]
2008-08-08 20:47 ` Daniel Walker
2008-08-08 21:24 ` [PATCH] [RFC] emit-crash-char: Allow diversion of printkoutput " Haller, John H (John)
2008-08-08 22:01 ` Daniel Walker
2008-08-11 23:34 ` [PATCH] [RFC] emit-crash-char: Allow diversion of printk output " David VomLehn
2008-08-12 22:39 ` Grant Likely
2008-08-13 1:30 ` David VomLehn
2008-08-13 2:12 ` Grant Likely
2008-08-13 17:56 ` David VomLehn
2008-08-13 19:02 ` Tim Bird
2008-08-13 20:27 ` David VomLehn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0808081313v4df788b9xcd25308ca64b0862@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=dvomlehn@cisco.com \
--cc=dwalker@mvista.com \
--cc=linux-embedded@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).